Skip to content

Commit

Permalink
Issue #15767: Add ModuleNotFoundError.
Browse files Browse the repository at this point in the history
  • Loading branch information
ericsnowcurrently committed Sep 7, 2016
1 parent 86a7668 commit c943265
Show file tree
Hide file tree
Showing 8 changed files with 42 additions and 2 deletions.
2 changes: 2 additions & 0 deletions Doc/c-api/exceptions.rst
Expand Up @@ -782,6 +782,8 @@ the variables:
+-----------------------------------------+---------------------------------+----------+
| :c:data:`PyExc_ImportError` | :exc:`ImportError` | |
+-----------------------------------------+---------------------------------+----------+
| :c:data:`PyExc_ModuleNotFoundError` | :exc:`ModuleNotFoundError` | |
+-----------------------------------------+---------------------------------+----------+
| :c:data:`PyExc_IndexError` | :exc:`IndexError` | |
+-----------------------------------------+---------------------------------+----------+
| :c:data:`PyExc_InterruptedError` | :exc:`InterruptedError` | |
Expand Down
13 changes: 11 additions & 2 deletions Doc/library/exceptions.rst
Expand Up @@ -170,8 +170,9 @@ The following exceptions are the exceptions that are usually raised.

.. exception:: ImportError

Raised when an :keyword:`import` statement fails to find the module definition
or when a ``from ... import`` fails to find a name that is to be imported.
Raised when the :keyword:`import` statement has troubles trying to
load a module. Also raised when the "from list" in ``from ... import``
has a name that cannot be found.

The :attr:`name` and :attr:`path` attributes can be set using keyword-only
arguments to the constructor. When set they represent the name of the module
Expand All @@ -181,6 +182,14 @@ The following exceptions are the exceptions that are usually raised.
.. versionchanged:: 3.3
Added the :attr:`name` and :attr:`path` attributes.

.. exception:: ModuleNotFoundError

A subclass of :exc:`ImportError` which is raised by :keyword:`import`
when a module could not be located. It is also raised when ``None``
is found in :data:`sys.modules`.

.. versionadded:: 3.6


.. exception:: IndexError

Expand Down
1 change: 1 addition & 0 deletions Include/pyerrors.h
Expand Up @@ -160,6 +160,7 @@ PyAPI_DATA(PyObject *) PyExc_EOFError;
PyAPI_DATA(PyObject *) PyExc_FloatingPointError;
PyAPI_DATA(PyObject *) PyExc_OSError;
PyAPI_DATA(PyObject *) PyExc_ImportError;
PyAPI_DATA(PyObject *) PyExc_ModuleNotFoundError;
PyAPI_DATA(PyObject *) PyExc_IndexError;
PyAPI_DATA(PyObject *) PyExc_KeyError;
PyAPI_DATA(PyObject *) PyExc_KeyboardInterrupt;
Expand Down
7 changes: 7 additions & 0 deletions Lib/_compat_pickle.py
Expand Up @@ -242,3 +242,10 @@

for excname in PYTHON3_OSERROR_EXCEPTIONS:
REVERSE_NAME_MAPPING[('builtins', excname)] = ('exceptions', 'OSError')

PYTHON3_IMPORTERROR_EXCEPTIONS = (
'ModuleNotFoundError',
)

for excname in PYTHON3_IMPORTERROR_EXCEPTIONS:
REVERSE_NAME_MAPPING[('builtins', excname)] = ('exceptions', 'ImportError')
1 change: 1 addition & 0 deletions Lib/test/exception_hierarchy.txt
Expand Up @@ -14,6 +14,7 @@ BaseException
+-- BufferError
+-- EOFError
+-- ImportError
+-- ModuleNotFoundError
+-- LookupError
| +-- IndexError
| +-- KeyError
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_pickle.py
Expand Up @@ -335,6 +335,9 @@ def test_name_mapping(self):
if (module2, name2) == ('exceptions', 'OSError'):
attr = getattribute(module3, name3)
self.assertTrue(issubclass(attr, OSError))
elif (module2, name2) == ('exceptions', 'ImportError'):
attr = getattribute(module3, name3)
self.assertTrue(issubclass(attr, ImportError))
else:
module, name = mapping(module2, name2)
if module3[:1] != '_':
Expand Down Expand Up @@ -401,6 +404,11 @@ def test_exceptions(self):
if exc is not OSError and issubclass(exc, OSError):
self.assertEqual(reverse_mapping('builtins', name),
('exceptions', 'OSError'))
elif exc is not ImportError and issubclass(exc, ImportError):
self.assertEqual(reverse_mapping('builtins', name),
('exceptions', 'ImportError'))
self.assertEqual(mapping('exceptions', name),
('exceptions', name))
else:
self.assertEqual(reverse_mapping('builtins', name),
('exceptions', name))
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS
Expand Up @@ -8043,6 +8043,9 @@ Core and Builtins
- Issue #18137: Detect integer overflow on precision in float.__format__()
and complex.__format__().

- Issue #15767: Introduce ModuleNotFoundError which is raised when a module
could not be found.

- Issue #18183: Fix various unicode operations on strings with large unicode
codepoints.

Expand Down
9 changes: 9 additions & 0 deletions Objects/exceptions.c
Expand Up @@ -705,6 +705,13 @@ ComplexExtendsException(PyExc_Exception, ImportError,
"Import can't find module, or can't find name in "
"module.");

/*
* ModuleNotFoundError extends ImportError
*/

MiddlingExtendsException(PyExc_ImportError, ModuleNotFoundError, ImportError,
"Module not found.");

/*
* OSError extends Exception
*/
Expand Down Expand Up @@ -2469,6 +2476,7 @@ _PyExc_Init(PyObject *bltinmod)
PRE_INIT(SystemExit)
PRE_INIT(KeyboardInterrupt)
PRE_INIT(ImportError)
PRE_INIT(ModuleNotFoundError)
PRE_INIT(OSError)
PRE_INIT(EOFError)
PRE_INIT(RuntimeError)
Expand Down Expand Up @@ -2541,6 +2549,7 @@ _PyExc_Init(PyObject *bltinmod)
POST_INIT(SystemExit)
POST_INIT(KeyboardInterrupt)
POST_INIT(ImportError)
POST_INIT(ModuleNotFoundError)
POST_INIT(OSError)
INIT_ALIAS(EnvironmentError, OSError)
INIT_ALIAS(IOError, OSError)
Expand Down

0 comments on commit c943265

Please sign in to comment.