diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py index ebaf7960401307..26c5dfe9261b7f 100644 --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -690,6 +690,16 @@ def read(self, size): self.assertEqual(stream.readinto(buffer), 5) self.assertEqual(buffer.tobytes(), b"12345") + def test_close_assert(self): + class R(self.IOBase): + def __setattr__(self, name, value): + pass + def flush(self): + raise OSError() + f = R() + # This would cause an assertion failure. + self.assertRaises(OSError, f.close) + class CIOTest(IOTest): diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-07-14-08-58-46.bpo-34068.9xfM55.rst b/Misc/NEWS.d/next/Core and Builtins/2018-07-14-08-58-46.bpo-34068.9xfM55.rst new file mode 100644 index 00000000000000..0ed8ff91925ab5 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2018-07-14-08-58-46.bpo-34068.9xfM55.rst @@ -0,0 +1,3 @@ +In :meth:`io.IOBase.close`, ensure that the :attr:`~io.IOBase.closed` +attribute is not set with a live exception. Patch by Zackery Spytz and Serhiy +Storchaka. diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c index d813daf6cfb354..17b905ad8fb65c 100644 --- a/Modules/_io/iobase.c +++ b/Modules/_io/iobase.c @@ -177,17 +177,25 @@ _PyIOBase_check_closed(PyObject *self, PyObject *args) static PyObject * iobase_close(PyObject *self, PyObject *args) { - PyObject *res; + PyObject *res, *exc, *val, *tb; + int rc; if (IS_CLOSED(self)) Py_RETURN_NONE; res = PyObject_CallMethodObjArgs(self, _PyIO_str_flush, NULL); - PyObject_SetAttrString(self, "__IOBase_closed", Py_True); + + PyErr_Fetch(&exc, &val, &tb); + rc = PyObject_SetAttrString(self, "__IOBase_closed", Py_True); + _PyErr_ReplaceException(exc, val, tb); + if (rc < 0) { + Py_CLEAR(res); + } + if (res == NULL) { return NULL; } - Py_XDECREF(res); + Py_DECREF(res); Py_RETURN_NONE; }