Skip to content

gh-111123: symtable should visit exception handlers before the else block #111142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 6 commits into from
Oct 21, 2023
Merged

gh-111123: symtable should visit exception handlers before the else block #111142

iritkatriel merged 6 commits into from
Oct 21, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 20, 2023 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 20, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2023
Closed
@iritkatriel iritkatriel requested a review from pablogsal October 20, 2023 22:17
@iritkatriel iritkatriel removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 21, 2023
iritkatriel and others added 3 commits October 21, 2023 11:47
@iritkatriel
except* too
72fd4d1
@iritkatriel
add what's new
2216553
@iritkatriel @pablogsal
typo
eafa6d1 
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@iritkatriel iritkatriel merged commit b578e51 into python:main Oct 21, 2023
AlexWaygood
AlexWaygood reviewed Oct 21, 2023
View reviewed changes
Doc/whatsnew/3.13.rst
the file is not accessible.
(Contributed by Moonsik Park in :gh:`82367`.)

* Fixed a bug where a :keyword:`global` decleration in an :keyword:`except` block
Copy link
Member

@AlexWaygood AlexWaygood Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be "declaration"

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-111123: symtable should visit exception handlers before the …
56242d5 
…else block (python#111142)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-111123: symtable should visit exception handlers before the …
dca6007 
…else block (python#111142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@AlexWaygood AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

global declaration in except has incorrect prior use

3 participants

@iritkatriel @pablogsal @AlexWaygood