Skip to content

gh-114875: Add getgrent as a prerequisite for building the grp module #114876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 3 commits into from
Feb 2, 2024
Merged

gh-114875: Add getgrent as a prerequisite for building the grp module #114876

erlend-aasland merged 3 commits into from
Feb 2, 2024

Conversation

@mhsmith
Copy link
Member

@mhsmith mhsmith commented Feb 1, 2024 •
edited
Loading

This allows the module to be correctly skipped on older versions of Android which don't have getgrent and related functions:

checking for getgrent... no
checking for getgrgid... yes
checking for getgrgid_r... no
[...]
checking for stdlib extension module grp... missing

@bedevere-app bedevere-app bot mentioned this pull request Feb 1, 2024
Closed
erlend-aasland
erlend-aasland reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mhsmith and others added 2 commits February 2, 2024 19:43
@mhsmith @erlend-aasland
Apply suggestions from code review
bb1fe58 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@mhsmith
Autoreconf
9cf79f3
@mhsmith
Copy link
Member Author

mhsmith commented Feb 2, 2024

Thanks; suggestions all applied.

@erlend-aasland erlend-aasland merged commit f35c7c0 into python:main Feb 2, 2024
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 2, 2024

Thanks again :)

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@mhsmith @erlend-aasland @aisk
pythongh-114875: Require getgrent for building the grp extension modu…
b5273ef 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@mhsmith @erlend-aasland @fsc-eriker
pythongh-114875: Require getgrent for building the grp extension modu…
73b7e69 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@mhsmith mhsmith deleted the grp-getgrent branch February 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grp module attempts to build even if getgrent family of functions are unavailable

2 participants

@mhsmith @erlend-aasland