Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 25, 2024

Handling of arbitrary large int-like argument is now consistent with handling arbitrary large int arguments.

Handling of arbitrary large int-like argument is now consistent with
handling arbitrary large int arguments.
@serhiy-storchaka
Copy link
Member Author

This is not optimal, because for large int-like argument __index__ is called twice and OverflowError is raised and silenced twice.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review June 26, 2024 13:37
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this pr has conflicts (which seems to be easy to fix, however).

Lets merge this; it has approval from Mark. LGTM with one cleanup, as _PyLong_Frexp() now not raises.

@serhiy-storchaka serhiy-storchaka merged commit 4359706 into python:main Nov 11, 2025
46 checks passed
@serhiy-storchaka serhiy-storchaka deleted the math-log-int-like-overflow branch November 11, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants