bpo-36260: Add pitfalls to zipfile module documentation #13378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement. So, we moved a little bit forward :P And the doc patch can be found (pr).
auvipy
approved these changes
May 29, 2019
Contributor
|
@krnick, your pull request is failing the CI builds because of trailing whitespace. Please correct that. Thank you! |
Contributor
Author
|
@csabella Sorry for the mistake, I have fixed it. |
Contributor
|
Request review from @tiran and @serhiy-storchaka based on this discussion on the bug tracker. |
|
@jaraco: Please replace |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
* bpo-36260: Add pitfalls to zipfile module documentation We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement. So, we moved a little bit forward :P And the doc patch can be found (pr). * fix trailing whitespace * 📜🤖 Added by blurb_it. * Reformat text for consistency. (cherry picked from commit 3ba51d5) Co-authored-by: JunWei Song <sungboss2004@gmail.com>
|
GH-15976 is a backport of this pull request to the 3.8 branch. |
jaraco
pushed a commit
that referenced
this pull request
Sep 11, 2019
…H-15976) * bpo-36260: Add pitfalls to zipfile module documentation We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement. So, we moved a little bit forward :P And the doc patch can be found (pr). * fix trailing whitespace * 📜🤖 Added by blurb_it. * Reformat text for consistency. (cherry picked from commit 3ba51d5) Co-authored-by: JunWei Song <sungboss2004@gmail.com>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
* bpo-36260: Add pitfalls to zipfile module documentation We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement. So, we moved a little bit forward :P And the doc patch can be found (pr). * fix trailing whitespace * 📜🤖 Added by blurb_it. * Reformat text for consistency.
tkarabela
added a commit
to tkarabela/cpython
that referenced
this pull request
Nov 30, 2022
Co-authored-by: Florent Xicluna <florent.xicluna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.
So, we moved a little bit forward :D
https://bugs.python.org/issue36260