bpo-36919: make test_source_encoding.test_issue2301 implementation-independent #13639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
May 29, 2019
jaraco
approved these changes
Sep 11, 2019
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
Looks good. If this pattern is extended to more than one other case, it will be advisable to extract the behavior as a helper function that describes the justification for the behavior.
|
@jaraco: Please replace |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
…dependent (pythonGH-13639) * bpo-36919: make test_issue2301 implementation-independent (cherry picked from commit b6643dc) Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
|
GH-15952 is a backport of this pull request to the 3.8 branch. |
|
GH-15953 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
…dependent (pythonGH-13639) * bpo-36919: make test_issue2301 implementation-independent (cherry picked from commit b6643dc) Co-authored-by: Pavel Koneski <pavel.koneski@gmail.com>
jaraco
pushed a commit
that referenced
this pull request
Sep 11, 2019
jaraco
pushed a commit
that referenced
this pull request
Sep 11, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
…dependent (python#13639) * bpo-36919: make test_issue2301 implementation-independent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36919