-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
bpo-37305: add MIME type for Web App Manifest #14199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
I signed the CLA today so it is currently not updated. |
|
Ok, it is now confirmed to be signed. |
|
I think you have also reformatted the dictionary and the indentation change makes the diff larger than the one line change done. |
|
@tirkarthi I indented all lines because |
jaraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks right to me.
|
I notice that previously the mapping was ordered by value alphabetically. We should retain that form. |
|
@jaraco: Please replace |
|
Thanks @filips123 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
* bpo-37305: add MIME type for Web App Manifest * bpo-37305: add news entry * Restore indentation and sort by value (cherry picked from commit 4b41745) Co-authored-by: Filip Š <filip.stamcar@hotmail.com>
|
GH-15946 is a backport of this pull request to the 3.8 branch. |
* bpo-37305: add MIME type for Web App Manifest * bpo-37305: add news entry * Restore indentation and sort by value
* bpo-37305: add MIME type for Web App Manifest * bpo-37305: add news entry * Restore indentation and sort by value
Add
.webmanifest->application/manifest+jsonto list of recognized file types and content type headers.Note that
application/manifest+jsonis currently not registered with IANA (but it will be soon), so I can move it tocommon_typesif needed.Issue: https://bugs.python.org/issue37305
https://bugs.python.org/issue37305