Skip to content

Conversation

@filips123
Copy link
Contributor

@filips123 filips123 commented Jun 18, 2019

Add .webmanifest -> application/manifest+json to list of recognized file types and content type headers.

Note that application/manifest+json is currently not registered with IANA (but it will be soon), so I can move it to common_types if needed.

Issue: https://bugs.python.org/issue37305

https://bugs.python.org/issue37305

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@filips123
Copy link
Contributor Author

I signed the CLA today so it is currently not updated.

@filips123
Copy link
Contributor Author

Ok, it is now confirmed to be signed.

@tirkarthi
Copy link
Member

I think you have also reformatted the dictionary and the indentation change makes the diff larger than the one line change done.

@filips123
Copy link
Contributor Author

@tirkarthi I indented all lines because .webmanifest key was too long.

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks right to me.

@jaraco
Copy link
Member

jaraco commented Sep 11, 2019

I notice that previously the mapping was ordered by value alphabetically. We should retain that form.

@jaraco jaraco self-assigned this Sep 11, 2019
@jaraco jaraco merged commit 4b41745 into python:master Sep 11, 2019
@bedevere-bot
Copy link

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @filips123 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
(cherry picked from commit 4b41745)

Co-authored-by: Filip Š <filip.stamcar@hotmail.com>
@bedevere-bot
Copy link

GH-15946 is a backport of this pull request to the 3.8 branch.

jaraco pushed a commit that referenced this pull request Sep 11, 2019
* bpo-37305: add MIME type for Web App Manifest

Co-authored-by: Filip Š <filip.stamcar@hotmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants