Skip to content

bpo-37627: Initialize IDLE Custom Run dialog with previous entries #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 21, 2019
Merged

bpo-37627: Initialize IDLE Custom Run dialog with previous entries #14870

merged 9 commits into from
Jul 21, 2019

Conversation

@nsiregar
Copy link
Contributor

@nsiregar nsiregar commented Jul 20, 2019 •
edited by terryjreedy
Loading

Repeat the command line arguments most recently entered before so the user can edit them.

https://bugs.python.org/issue37627

@nsiregar nsiregar requested a review from terryjreedy as a code owner July 20, 2019 16:35
@terryjreedy terryjreedy changed the title bpo-3726: IDLE: Improve menu option run customized bpo-37627: IDLE: Improve menu option run customized Jul 20, 2019
@nsiregar nsiregar force-pushed the bpo-37627-minor-improvement-idle branch from 85b1f40 to cf1aee9 Compare July 20, 2019 16:55
@terryjreedy
Copy link
Member

terryjreedy commented Jul 20, 2019

Please be very careful with bpo numbers when submitting. To fix, one must go the wrong issue and remove the misplaced link, then change the number in the title and 3 places in the comment. (This should be in the devguide.)

terryjreedy
terryjreedy requested changes Jul 20, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tracker issue and this PR are about two different subjects: the Run menu and persisting user command line entries. I will want these split, but can't now say what change to make.

So don't do anything immediately.

@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rhettinger
Copy link
Contributor

rhettinger commented Jul 20, 2019

Can we get this done before 3.8 goes final? The user testing indicated that both sub-issues were problematic. That said, I'm happy to have the feature at all. It was a nice improvment for developing command-line scripts using IDLE.

@terryjreedy terryjreedy changed the title bpo-37627: IDLE: Improve menu option run customized bpo-37627: IDLE -- persist custom run arguments Jul 21, 2019
@terryjreedy terryjreedy self-assigned this Jul 21, 2019
@terryjreedy terryjreedy added needs backport to 3.7 type-feature A feature request or enhancement labels Jul 21, 2019
@terryjreedy terryjreedy changed the title bpo-37627: IDLE -- persist custom run arguments bpo-37627: Initialize IDLE Custom Run dialog with previous entires Jul 21, 2019
@terryjreedy terryjreedy changed the title bpo-37627: Initialize IDLE Custom Run dialog with previous entires bpo-37627: Initialize IDLE Custom Run dialog with previous entries Jul 21, 2019
@terryjreedy
Copy link
Member

terryjreedy commented Jul 21, 2019 •
edited
Loading

I want to split the menu change, for which I have an alternative proposal, from the argument persistence, which I was going to merge by tomorrow. I did not realize that 'delete file' meant 'delete the whole file' as opposed to the changes to the file, so I have to patch this PR or write another. There does not seem to be a way in the UI to revert a deletion.

@nsiregar
Copy link
Contributor Author

nsiregar commented Jul 21, 2019

Yeah, Siregar it is

@terryjreedy terryjreedy merged commit 35b87e6 into python:master Jul 21, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jul 21, 2019

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2019

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2019
@nsiregar @miss-islington
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
52c16f8 
…ythonGH-14870)

Repeat the command line arguments most recently entered before so the user can edit them.
(cherry picked from commit 35b87e6)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2019

GH-14881 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2019
@nsiregar @miss-islington
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
6f894f8 
…ythonGH-14870)

Repeat the command line arguments most recently entered before so the user can edit them.
(cherry picked from commit 35b87e6)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2019

GH-14882 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jul 21, 2019
@miss-islington @nsiregar
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (G…
d9086f2 
…H-14870)

Repeat the command line arguments most recently entered before so the user can edit them.
(cherry picked from commit 35b87e6)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 21, 2019

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 21, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Jul 21, 2019

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2019
@nsiregar @miss-islington
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
f20dd51 
…ythonGH-14870)

Repeat the command line arguments most recently entered before so the user can edit them.
(cherry picked from commit 35b87e6)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2019

GH-14893 is a backport of this pull request to the 3.8 branch.

@terryjreedy
Copy link
Member

terryjreedy commented Jul 21, 2019

@Mariatta I have re-added 'needs backport to 3.8' twice with no response at all after several minutes

@Mariatta
Copy link
Member

Mariatta commented Jul 21, 2019

The last one seemed to work

miss-islington added a commit that referenced this pull request Jul 21, 2019
@miss-islington @nsiregar
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (G…
9325f40 
…H-14870)

Repeat the command line arguments most recently entered before so the user can edit them.
(cherry picked from commit 35b87e6)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@nsiregar @lisroach
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
7a5309c 
…ython#14870)

Repeat the command line arguments most recently entered before so the user can edit them.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@nsiregar @DinoV
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
d5a6478 
…ython#14870)

Repeat the command line arguments most recently entered before so the user can edit them.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@nsiregar @websurfer5
bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…
cdb047b 
…ython#14870)

Repeat the command line arguments most recently entered before so the user can edit them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nsiregar @terryjreedy @bedevere-bot @rhettinger @miss-islington @Mariatta @the-knights-who-say-ni