bpo-37228: Fix warnings in test_asyncio.test_base_events

[aeros]

Co-authored-by: @tirkarthi

The security patch #17311 (which was backported to 3.8, 3.7, and 3.6) added a few subtle warnings, including a ResourceWarning and two DeprecationWarnings in test_asyncio.test_base_events. @tirkarthi discovered the warnings, and proposed a fix for the ResourceWarning. See the bpo issue for more details.

https://bugs.python.org/issue37228

[ambv]

Wasn't the point of the security fix to not use reuse_addr=?

[aeros]

@ambv

Wasn't the point of the security fix to not use reuse_addr=?

The primary point of the security fix was to specifically remove usage of reuse_addr=True for create_datagram_endpoint() and no longer use it as a default. But as a part of it we also deprecated the reuse_address parameter itself since it was turned into a no-op. This PR is simply addressing some minor test changes that I missed, which @tirkarthi picked up on by running the tests with -Wall.

I accidentally introduced a couple deprecation warnings that were raised from previous tests that still had reuse_address=False, which should have been removed. Also, in the actual test for the deprecation warning, the transport and protocol were not closed, leading to a resource warning.

It wouldn't be the end of the world if this didn't make it into the next releases, but it would definitely be preferable to not have additional warnings lingering in the regression tests. Especially in this case where the fix is quite simple.

[bedevere-bot]

@ambv: Please replace # with GH- in the commit message next time. Thanks!

[miss-islington]

Thanks @aeros for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8.
🐍🍒⛏🤖

[ambv]

Thanks! ✨ 🍰 ✨

[bedevere-bot]

GH-17579 is a backport of this pull request to the 3.8 branch.

[bedevere-bot]

GH-17580 is a backport of this pull request to the 3.7 branch.

[bedevere-bot]

GH-17581 is a backport of this pull request to the 3.6 branch.

[tirkarthi]

Thanks @aeros :)