bpo-39114: Fix handling of line numbers around finally-blocks. #17737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You need to regenerate the frozen importlib and other frozen stuff, no? ( |
markshannon
force-pushed
the
fix-linenumbers-around-finallly-blocks
branch
from
f3b9fbe to
f254546
Compare
pablogsal
approved these changes
Dec 29, 2019
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the fix!
|
@markshannon: Please replace |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the line number after emitting the code for a finally block.
https://bugs.python.org/issue39114