[3.9] bpo-43295: Fix error handling of datetime.strptime format string '%z' (GH-24627) #25695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-24627) Previously, `datetime.strptime` would match `'z'` with the format string `'%z'` (for UTC offsets), throwing an `IndexError` by erroneously trying to parse `'z'` as a timestamp. As a special case, `'%z'` matches the string `'Z'` which is equivalent to the offset `'+00:00'`, however this behavior is not defined for lowercase `'z'`. This change ensures a `ValueError` is thrown when encountering the original example, as follows: ``` >>> from datetime import datetime >>> datetime.strptime('z', '%z') ValueError: time data 'z' does not match format '%z' ``` Automerge-Triggered-By: GH:pganssle (cherry picked from commit 04f6fbb) Co-authored-by: Noor Michael <nsmichael31@gmail.com>
Member
|
Should this be merged? |
pganssle
approved these changes
May 20, 2021
Member
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
@iritkatriel I believe so! Thanks!
|
@pganssle: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
datetime.strptimewould match'z'with the format string'%z'(for UTC offsets), throwing anIndexErrorby erroneously trying to parse'z'as a timestamp. As a special case,'%z'matches the string'Z'which is equivalent to the offset'+00:00', however this behavior is not defined for lowercase'z'.This change ensures a
ValueErroris thrown when encountering the original example, as follows:Automerge-Triggered-By: GH:pganssle
(cherry picked from commit 04f6fbb)
Co-authored-by: Noor Michael nsmichael31@gmail.com
https://bugs.python.org/issue43295