Minimal cleanup of run.py

[mdehoon]

BPO	1190163
Nosy	@kbkaiser
Files	run.py.diff: Patch to run.py in Lib/idlelib

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kbkaiser'
closed_at = <Date 2005-05-05.23:30:33.000>
created_at = <Date 2005-04-26.10:50:29.000>
labels = ['expert-IDLE']
title = 'Minimal cleanup of run.py'
updated_at = <Date 2005-05-05.23:30:33.000>
user = 'https://bugs.python.org/mdehoon'

bugs.python.org fields:

activity = <Date 2005-05-05.23:30:33.000>
actor = 'kbk'
assignee = 'kbk'
closed = True
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2005-04-26.10:50:29.000>
creator = 'mdehoon'
dependencies = []
files = ['6633']
hgrepos = []
issue_num = 1190163
keywords = ['patch']
message_count = 2.0
messages = ['48261', '48262']
nosy_count = 2.0
nosy_names = ['kbk', 'mdehoon']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1190163'
versions = []

[mdehoon]

In the main function in run.py in Lib/idlelib, we have

try:
seq, request = rpc.request_queue.get(0)
except Queue.Empty:
time.sleep(0.05)
continue

The get method of rpc.request_queue already has the
option of a timeout, so we can use that instead of
inlining time.sleep:

try:
seq, request = rpc.request_queue.get(block=True,

 timeout=0.05)

except Queue.Empty:
continue

resulting in a (small) simplication of the code. The
patch was tested on Windows, Linux, and Mac OS X.

In case you are wondering why I care about this:
My real interest is in PyOS_InputHook, a pointer to a
function which is called ten times per second when
Python is idle (e.g., waiting for user input).
Currently, calls to PyOS_InputHook are missing in some
cases where Python goes idle. I am going through the
code to fix this. Now, since both the original code in
run.py and rpc.request_queue.get cause Python to go
idle (by calling the sleep function), it means that I
would have to fix both cases. By making use of the
existing code in rpc.request_queue.get, I need to fix
this routine only (which I will do in a later patch),
and avoids having calls to PyOS_InputHook all over the
place.

[kbkaiser]

Logged In: YES
user_id=149084

run.py rev 1.32