Redefine clear() for os.environ to use unsetenv() if possible

[martinhorcicka]

BPO	1181
Nosy	@gvanrossum, @birkenfeld
Files	os.py.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2007-09-20.17:59:03.671>
created_at = <Date 2007-09-19.21:38:22.549>
labels = ['type-bug', 'library']
title = 'Redefine clear() for os.environ to use unsetenv() if possible'
updated_at = <Date 2007-09-20.17:59:03.669>
user = 'https://bugs.python.org/martinhorcicka'

bugs.python.org fields:

activity = <Date 2007-09-20.17:59:03.669>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2007-09-20.17:59:03.671>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2007-09-19.21:38:22.549>
creator = 'martin.horcicka'
dependencies = []
files = ['8451']
hgrepos = []
issue_num = 1181
keywords = ['patch']
message_count = 5.0
messages = ['56048', '56060', '56061', '56063', '56064']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'georg.brandl', 'draghuram', 'martin.horcicka']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1181'
versions = []

[martinhorcicka]

This patch makes os.environ.clear() to have the same effect as:

for name in os.environ.keys():
    del os.environ[name]

I believe that most people expect the effects to be the same anyway.

The practical benefit is a simpler redefinition of the whole environment
if desired (e.g. in scripts run via sudo on unix systems).

[gvanrossum]

Sounds like a good idea. Anyone care to check it in?

[draghuram]

Shouldn't the first clear() in the patch say "del
self.data[key.upper()]" instead of "del self.data[key]"? I also think
the patch should include doc change.

[gvanrossum]

On 9/20/07, Raghuram Devarakonda <report@bugs.python.org> wrote:

Shouldn't the first clear() in the patch say "del
self.data[key.upper()]" instead of "del self.data[key]"? I also think
the patch should include doc change.

I don't think so -- it goes over self.data.keys() which means they are
already uppercase.

All of this would be unnecessary if clear() in UserDict were to be changed to

for key in self.keys(): del self[key]

But that's a much more pervasive change...

[birkenfeld]

Committed, incl. docs, as rev. 58221.