tkinter, assorted fixes

[gpolo]

BPO	2906
Nosy	@birkenfeld
Files	fixes_Tkinter.diff tkinter_tuple_list_support.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-06-03.10:26:36.793>
created_at = <Date 2008-05-18.15:38:56.291>
labels = ['expert-tkinter']
title = 'tkinter, assorted fixes'
updated_at = <Date 2008-06-03.10:26:36.746>
user = 'https://bugs.python.org/gpolo'

bugs.python.org fields:

activity = <Date 2008-06-03.10:26:36.746>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2008-06-03.10:26:36.793>
closer = 'georg.brandl'
components = ['Tkinter']
creation = <Date 2008-05-18.15:38:56.291>
creator = 'gpolo'
dependencies = []
files = ['10440', '10504']
hgrepos = []
issue_num = 2906
keywords = ['patch']
message_count = 5.0
messages = ['67029', '67351', '67474', '67646', '67652']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'gpolo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2906'
versions = ['Python 3.0']

[gpolo]

This patch adds support for Tk options that could be passed as a list or
tuple, for example. I didn't investigate if there are any of these in tk
8.4, but tk 8.5 has this (the padding option for Ttk Label, for example).
Note that this should, if possible, be backported to python 2.5 at
least, since it segfaults here when I pass a list as an option value.

It also aligns some docstrings; documents the support for the 'in_'
option for grid, place and pack, actually all options may end with an
"_", but it is good to document 'in_' specifically because the option
'in' can't be passed "naturally". Lastly it removes the duplicate code
in class Place that checks for the 'in_' option.

[gpolo]

I found a problem in the previous patch, new one added. This patch now
only considers tuple and list as possible option value that should be
joined, and the items inside the list or tuple should be either a string
or integer, otherwise it doesn't try to join the values.

The problem in the previous patch is that it would always join the value
independent of the value's content. But if an option is composed of a
tuple of tuples (used by dialogs), this conversion shouldn't be done.

[birkenfeld]

Committed as r63776, r63777 (3k).

[gpolo]

I found a case where the support for values under list or tuple would
fail, when the contents contain spaces it needs a proper tcl formatting.
I'm attaching a new patch that fixes this.

[birkenfeld]

Applied in trunk, 25-maint and 3k.