Remove uses of nb_long slot, and rename to nb_reserved. #49160
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee = 'https://github.com/benjaminp' closed_at = <Date 2009-02-11.17:07:06.097> created_at = <Date 2009-01-10.20:32:22.374> labels = ['type-bug'] title = 'Remove uses of nb_long slot, and rename to nb_reserved.' updated_at = <Date 2009-02-11.17:07:06.096> user = 'https://github.com/mdickinson'
activity = <Date 2009-02-11.17:07:06.096> actor = 'mark.dickinson' assignee = 'benjamin.peterson' closed = True closed_date = <Date 2009-02-11.17:07:06.097> closer = 'mark.dickinson' components =  creation = <Date 2009-01-10.20:32:22.374> creator = 'mark.dickinson' dependencies =  files = ['12696', '12697', '12754', '12756', '12781'] hgrepos =  issue_num = 4910 keywords = ['patch'] message_count = 13.0 messages = ['79571', '79581', '79655', '79659', '79689', '79902', '79907', '79913', '79918', '79973', '80031', '80055', '81652'] nosy_count = 2.0 nosy_names = ['mark.dickinson', 'benjamin.peterson'] pr_nums =  priority = 'critical' resolution = 'fixed' stage = None status = 'closed' superseder = None type = 'behavior' url = 'https://bugs.python.org/issue4910' versions = ['Python 3.0', 'Python 3.1']
The text was updated successfully, but these errors were encountered:
Here's a patch against the py3k branch that gets rid of the two existing
With this patch, all tests pass on my (OS X 10.5/Intel) machine.
If someone can review this quickly I'll move on to the next patch towards
I think it would be good if nb_long could be altered before 3.0.1.
Benjamin, do you have time to take a look?
Thanks, Benjamin! Checked in in r68553, backported to 3.0 in r68556.
Here's the second patch, which fixes almost all remaining uses of nb_long
(1) I haven't tested the change to PC/winreg.c
(2) The Modules/_struct.c change does introduce a change in behaviour:
raises struct.error. After the patch, the packing succeeds. I *think*
On Thu, Jan 15, 2009 at 10:48 AM, Mark Dickinson <firstname.lastname@example.org> wrote:
This looks correct. In fact, I don't really see the point of having
Since Decimal implements __int__ and that's what the struct module is
Overall, the patch looks fine. I wonder if we should mark
It would be nice to standardize on one of (PyNumber_Long, PyNumber_Int)
Maybe it would make more sense to stick with PyNumber_Long and deprecate
Here's a patch that deprecates PyNumber_Int in favour of PyNumber_Long:
I suppose that in theory this goes too far: we should really deprecate in
N.B. We should remember to actually remove intobject.h for 3.1. :)