Add xz support to shutil

[proyvind]

BPO	5411
Nosy	@pitrou, @tarekziade, @merwok, @4kir4, @berkerpeksag, @hynek, @serhiy-storchaka
Dependencies	bpo-5689: Support xz compression in tarfile module
Files	shutil-lzma_3.patch docs-fix-sphinx-warning.patch: fix sphinx's whitespace/indentation warning

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-08-06.15:58:54.643>
created_at = <Date 2009-03-03.11:56:24.716>
labels = ['type-feature', 'library']
title = 'Add xz support to shutil'
updated_at = <Date 2014-08-11.15:11:21.692>
user = 'https://bugs.python.org/proyvind'

bugs.python.org fields:

activity = <Date 2014-08-11.15:11:21.692>
actor = 'berker.peksag'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-08-06.15:58:54.643>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2009-03-03.11:56:24.716>
creator = 'proyvind'
dependencies = ['5689']
files = ['32163', '36342']
hgrepos = []
issue_num = 5411
keywords = ['patch']
message_count = 34.0
messages = ['83072', '83263', '83401', '83404', '111038', '115780', '148660', '152748', '152749', '153131', '153351', '153831', '153832', '153834', '153937', '153938', '154029', '173831', '173833', '174491', '174707', '199977', '199987', '200183', '224471', '224722', '224771', '224780', '224943', '224944', '224945', '224946', '225181', '225193']
nosy_count = 11.0
nosy_names = ['pitrou', 'nadeem.vawda', 'tarek', 'eric.araujo', 'Arfrever', 'proyvind', 'akira', 'python-dev', 'berker.peksag', 'hynek', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5411'
versions = ['Python 3.5']

[proyvind]

Here's a patch that adds support for xz compression:
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/python/current/SOURCES/Python-2.6.1-distutils-xz-support.patch?view=log

[tarekziade]

Good idea !

are you able provide a unit test for the changes made into the two
commands ?

[proyvind]

hmm, I'm unsure about how this should be done..

I guess such a test would belong in Lib/distutils/test_dist.py, but I'm
uncertain about how it should be done, ie. should it be a test for doing
'bdist', 'bdist_rpm' and 'sdist' for each of the formats supported? I
cannot seem to find any tests for the currently supported formats and
such tests would introduce dependencies on the tools used to compress
with these formats..

[tarekziade]

I guess such a test would belong in Lib/distutils/test_dist.py

no, rather in test_bdist_rpm, test_sdist and so on,
but I can do it, it'll just take more time.

[merwok]

distutils2 uses tarfile now instead of external programs. Adding dependency on another bug.

[merwok]

FTR, the distutils2 repo is http://bitbucket.org/tarek/distutils2. distutils2.tests.support contains helper to create temp directories and run commands; see docstrings and example uses in the tests for more info.

[merwok]

distutils2/packaging now just uses the shutil functions. I’ll make a patch for shutil after tarfile is updated.