Add PyOS_string_to_double function to C API

[mdickinson]

BPO	5914
Nosy	@mdickinson, @ericvsmith
Files	string_to_double.patch string_to_double_v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mdickinson'
closed_at = <Date 2009-05-03.20:36:24.613>
created_at = <Date 2009-05-03.15:27:14.613>
labels = ['interpreter-core', 'type-feature']
title = 'Add PyOS_string_to_double function to C API'
updated_at = <Date 2009-05-03.20:36:24.611>
user = 'https://github.com/mdickinson'

bugs.python.org fields:

activity = <Date 2009-05-03.20:36:24.611>
actor = 'mark.dickinson'
assignee = 'mark.dickinson'
closed = True
closed_date = <Date 2009-05-03.20:36:24.613>
closer = 'mark.dickinson'
components = ['Interpreter Core']
creation = <Date 2009-05-03.15:27:14.613>
creator = 'mark.dickinson'
dependencies = []
files = ['13852', '13853']
hgrepos = []
issue_num = 5914
keywords = ['patch']
message_count = 5.0
messages = ['87048', '87049', '87055', '87057', '87068']
nosy_count = 2.0
nosy_names = ['mark.dickinson', 'eric.smith']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5914'
versions = ['Python 3.1']

[mdickinson]

Here's a patch that adds a PyOS_string_to_double function to complement
the recently added PyOS_double_to_string function.

This is supposed to be a more Pythonic version of PyOS_ascii_strtod. It
raises Python exceptions to correspond to the various possible errors
(malformed string, overflowing number, malloc failure...) instead of
requiring the caller to examine errno.

It's intended for both internal and external use; if this goes in, I
intend to use it in the Python core in places where PyOS_ascii_strtod or
PyOS_ascii_atof are currently used.

[ericvsmith]

This looks okay to me (although since it's not hooked up I haven't
tested it). I particularly like that it doesn't allow leading
whitespace, and that the caller no longer has to remember errno
(forgetting to set and/or test it have both caused me problems in the past).

Does the whitespace change cause any problems for any internal code? I
wouldn't think so, but I haven't looked at it.

As long as you're at it, I'd suggest deprecating PyOS_ascii_*.

[mdickinson]

Thanks for the feedback!

Here's an updated patch that also deprecates PyOS_ascii_strtod and
PyOS_ascii_atof and hooks up PyOS_string_to_double everywhere. The
documentation still needs proper markup, and I'll add some C-API tests.

[ericvsmith]

This looks okay to me, and passes the tests.

In PyOS_string_to_double, you can simplify it by using PyErr_Format
instead of printing into a buffer and using PyErr_SetString. Sorry I
didn't catch this earlier.

[mdickinson]

Thanks. I've committed a version of this patch, with Eric's suggested
PyErr_Format change, in r72248.