-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
ZipFile.writestr "compression_type" argument #50253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Class zipfile.ZipFile has two methods for adding data to a zipfile: The former has a "compression_type" argument that can be used to specify Could a "compression_type" argument be added to "writestr" as well? I The other alternative is to use a ZipInfo object as the archive-name of |
This sounds like a good idea. Can you provide a patch (including tests)? |
I will. I guess it's too late to merge this into 3.1 (as the first beta has |
Since the change should be small and uncontroversial, I think it could |
The attached patch implements my proposal, including documentation and |
Argh... The patch includes an update to configure.in, please ignore that |
The patch looks ok. It can certainly go in trunk, as for 3.1 it's up to |
Committed in r78097 (trunk) and r78098 (3.2). This includes the documentation change suggested in msg88437 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: