add disable_nagle_algorithm to SocketServer.TCPServer

[kristjanvalur]

BPO	6192
Nosy	@pitrou, @kristjanvalur
Files	disable_nagle.patch socketserver2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kristjanvalur'
closed_at = <Date 2009-06-28.21:36:06.730>
created_at = <Date 2009-06-04.10:32:40.545>
labels = ['easy', 'type-feature', 'library']
title = 'add disable_nagle_algorithm to SocketServer.TCPServer'
updated_at = <Date 2009-06-28.21:36:06.729>
user = 'https://github.com/kristjanvalur'

bugs.python.org fields:

activity = <Date 2009-06-28.21:36:06.729>
actor = 'kristjan.jonsson'
assignee = 'kristjan.jonsson'
closed = True
closed_date = <Date 2009-06-28.21:36:06.730>
closer = 'kristjan.jonsson'
components = ['Library (Lib)']
creation = <Date 2009-06-04.10:32:40.545>
creator = 'kristjan.jonsson'
dependencies = []
files = ['14185', '14306']
hgrepos = []
issue_num = 6192
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['88878', '88886', '89046', '89062', '89411', '89657', '89795']
nosy_count = 2.0
nosy_names = ['pitrou', 'kristjan.jonsson']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue6192'
versions = ['Python 3.2']

[kristjanvalur]

It is useful to be able to disable the Nagle algoritm on socket
connections from the TCPServer. These are typically used by HTTP servers.

If combined with write buffering (setting RequestHangler.wbufsize = -1) it
can make sure that http responses are not subject to Nagle/Delayed-ack
delays. Disabling Nagle in addition to providing the buffering is
necessary to make sure that the final wfile.flush() arrives promptly, in
case a previous flush occurred and the final flush is small.

A patch is provided.

[pitrou]

Looks ok to me.

[kristjanvalur]

Committed in revision 73272

[pitrou]

This patch should be committed to py3k after 3.1 is released.

[kristjanvalur]

On consideration, it is more appropariate to have the
disable_nagle_algorithm as part of StreamRequestHandler rather than in the
TCPSockerServer. It then sits right next to the rfile and wfile that
affect it.
The RequestHandlers aren't documented as extensively as the socket
servers, though, so the documentation will have to go.
Attached is a patch.

[kristjanvalur]

Second patch applied in 73546

[kristjanvalur]

Merged into py3k in revision 73648