Cumulative patcc:h to http and xmlrpc

[kristjanvalur]

BPO	6267
Nosy	@loewis, @terryjreedy, @amauryfa, @kristjanvalur, @vstinner, @ezio-melotti, @bitdancer

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kristjanvalur'
closed_at = <Date 2009-12-13.18:04:05.217>
created_at = <Date 2009-06-11.15:30:34.513>
labels = ['library', 'performance']
title = 'Cumulative patcc:h to http and xmlrpc'
updated_at = <Date 2009-12-13.18:04:05.216>
user = 'https://github.com/kristjanvalur'

bugs.python.org fields:

activity = <Date 2009-12-13.18:04:05.216>
actor = 'r.david.murray'
assignee = 'kristjan.jonsson'
closed = True
closed_date = <Date 2009-12-13.18:04:05.217>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2009-06-11.15:30:34.513>
creator = 'kristjan.jonsson'
dependencies = []
files = []
hgrepos = []
issue_num = 6267
keywords = []
message_count = 17.0
messages = ['89254', '89255', '89586', '89775', '89786', '89799', '89968', '90042', '90060', '90088', '90089', '90460', '90600', '92597', '92600', '92602', '92606']
nosy_count = 7.0
nosy_names = ['loewis', 'terry.reedy', 'amaury.forgeotdarc', 'kristjan.jonsson', 'vstinner', 'ezio.melotti', 'r.david.murray']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue6267'
versions = ['Python 2.7', 'Python 3.2']

[kristjanvalur]

Please see
http://codereview.appspot.com/73041/show

[kristjanvalur]

Consider this a superset of
http://bugs.python.org/issue6099
http://bugs.python.org/issue6096

[terryjreedy]

On Py-dev, Fredrik Lundh wrote "The xmlrpclib.py changes looks ok. I'll
leave it to other reviewers to check the rest."

[loewis]

Patch set 4 looks fine to me, please apply it to 2.7 and 3.2.

[kristjanvalur]

Commited to 2.7 in revision 73638

[kristjanvalur]

I'm working on the 3.2 port, it needs some manual work.

[kristjanvalur]

committed to py3k in revision 73742

[bitdancer]

Before r73742, test_socketserver and test_urllib2_localnet work, after
this patchset is applied there are failures. This is on Gentoo linux,
py3k. See also bpo-6381 and bpo-6382, which are the same problems
on trunk. (The test_urllib2_localnet failure seems to now be
consistently repeatable on my machine, for whatever reason.)

[amauryfa]

The port to py3k has an error, see
http://mail.python.org/pipermail/python-checkins/2009-July/084734.html

Indexing is no more allowed on exception objects. it may be replaced
with e.args[0], or better, with e.errno.

[kristjanvalur]

Fixed exception handling in
revision 73820
and
revision 73821 and revision 73822

[kristjanvalur]

I've submitted a fix to 6381 in the trunk. 6382 is less clear to me, I
must take a closer look.

[kristjanvalur]

Added more regression tests in revision 73986 and revision 73987

[ezio-melotti]

xmlrpclib, DocXMLRPCServer and SimpleXMLRPCServer cannot be imported
after r73638 if zlib is missing, see bpo-6499.

[vstinner]

I opened a bug report introduced by this issue: bpo-6907:
xmlrpclib.make_connection() is not thread safe.

[vstinner]

There are duplicate issues about HTTP/1.1: bpo-2076, bpo-1767370.

[vstinner]

Another duplicate: bpo-1613573.

[vstinner]

Ok, all duplicate issues are now closed (bpo-1613573, bpo-1767370, bpo-2076).