New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add worker process lifetime to multiprocessing.Pool - patch included #51212
Comments
Worker processes with multiprocessing.Pool live for the duration of the Similarly, if one task passed to the pool allocates a large amount of A common approach to this problem (as used by Apache, mod_wsgi, and |
Hi Charles; I don't see a doc update for this (see multiprocessing.rst) or |
Alright, I'll add those. Thanks for looking at it; first pass was |
Updated patch attached; handles some of the Pool methods that weren't |
Jesse: this is ready for your review now. Thanks, Charles |
Can someone review this patch? I believe it's sufficient for inclusion |
I plan on reviewing the patch once my work with PyCon is completed, which |
Okay, thanks, Jesse. Didn't realize the Con was on. |
Well, it's in feb, but I'm involved in some intense planning right now. |
Hi Jesse -- Any chance you'll be able to review this in time for it to Charles |
On Sat, Nov 14, 2009 at 11:43 AM, Charles Cazabon
2.7 isn't slated until next year some time, so yes. |
Ping... two alphas into 2.7. Have you had a chance to review this functionality? Thanks. |
I'm fine with the functionality; I'm going to test it out and look at committing it by mid-week next week. I apologize, I've been pretty maxed out. |
No problem, Jesse, I realize you're busy. I've updated the patch very slightly to handle an issue I had where the worker maintainer hung once. |
I'm working on this now; I'm going to need to port the patch to trunk before moving forward with it. Shouldn't take me long. |
Attached is the ported patch for Python 2.7/trunk. Please review it to make sure I didn't completely flub anything. I noticed you had forgotten the maxtasksperchild argument in the unit test, so I added that. I also expanded the docs a little but, paraphrasing your original post w.r.t to the justification. Let me know what you think, or if you have issues. Once you give the go ahead, I will commit to trunk and then merge to Py3k. Once again, thanks for the patch |
Thanks, Jesse -- it looks good. If there are bugs remaining in the patch, they're mine and not yours. |
Committed to trunk in r77794 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: