Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inet_ntop and inet_pton support for Windows #51420

Closed
jaraco opened this issue Oct 19, 2009 · 8 comments
Closed

Add inet_ntop and inet_pton support for Windows #51420

jaraco opened this issue Oct 19, 2009 · 8 comments
Labels
easy extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@jaraco
Copy link
Member

jaraco commented Oct 19, 2009

BPO 7171
Nosy @atsuoishimoto, @jaraco, @giampaolo, @tiran
Files
  • issue7171.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-12-22.20:50:58.544>
    created_at = <Date 2009-10-19.23:20:24.681>
    labels = ['extension-modules', 'easy', 'type-feature']
    title = 'Add inet_ntop and inet_pton support for Windows'
    updated_at = <Date 2014-03-08.02:38:24.804>
    user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2014-03-08.02:38:24.804>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-12-22.20:50:58.544>
    closer = 'pitrou'
    components = ['Extension Modules']
    creation = <Date 2009-10-19.23:20:24.681>
    creator = 'jaraco'
    dependencies = []
    files = ['26392']
    hgrepos = []
    issue_num = 7171
    keywords = ['patch', 'easy']
    message_count = 8.0
    messages = ['94261', '110982', '165572', '171560', '171561', '202550', '202555', '212920']
    nosy_count = 10.0
    nosy_names = ['ishimoto', 'jaraco', 'ghazel', 'giampaolo.rodola', 'christian.heimes', 'Steven.Hayter', 'kookwekker', 'honglei.jiang', 'python-dev', 'pystranger']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue7171'
    versions = ['Python 3.4']

    @jaraco
    Copy link
    Member Author

    jaraco commented Oct 19, 2009

    According to the documentation, Microsoft now supports inet_ntop and
    inet_pton
    (http://msdn.microsoft.com/en-us/library/cc805843%28VS.85%29.aspx). This
    capability should be integrated into the socket module so it is
    supported cross-platform.

    @jaraco jaraco added topic-IO type-feature A feature request or enhancement labels Oct 19, 2009
    @ghazel
    Copy link
    Mannequin

    ghazel mannequin commented Jul 21, 2010

    In addition, inet_ntop and inet_pton can be implemented on Windows platforms prior to Vista using WSAAddressToStringA and WSAStringToAddressA.

    @pitrou pitrou added easy stdlib Python modules in the Lib dir and removed OS-windows topic-IO labels Sep 1, 2011
    @atsuoishimoto
    Copy link
    Mannequin

    atsuoishimoto mannequin commented Jul 16, 2012

    Implementation of inet_pton and inet_ntop by WSAAddressToStringA and
    WSAStringToAddressA for Windows.

    Conversion of IPv6 address might fail if IPv6 is
    not installed.

    Tested on Windows XP SP3 and Windows7.

    @pystranger
    Copy link
    Mannequin

    pystranger mannequin commented Sep 29, 2012

    I can't do that but I think the stage of the bug should be changed to "patch review" instead of "needs patch".

    @tiran
    Copy link
    Member

    tiran commented Sep 29, 2012

    As it's a new feature it must go into 3.4.

    @tiran tiran added extension-modules C modules in the Modules dir and removed stdlib Python modules in the Lib dir labels Sep 29, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 10, 2013

    New changeset 17b160baa20f by Atsuo Ishimoto in branch 'default':
    Issue bpo-7171: Add Windows implementation of inet_ntop and inet_pton to socket module.
    http://hg.python.org/cpython/rev/17b160baa20f

    New changeset a21f506d04c9 by Jason R. Coombs in branch 'default':
    Issue bpo-7171: Update syntax to replace MAX in favor of Py_MAX (matching implementation for Unix).
    http://hg.python.org/cpython/rev/a21f506d04c9

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 10, 2013

    New changeset 31fe38f95c82 by Jason R. Coombs in branch 'default':
    Update Misc/NEWS for Issue bpo-7171
    http://hg.python.org/cpython/rev/31fe38f95c82

    @pitrou pitrou closed this as completed Dec 22, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 8, 2014

    New changeset f82145a516f0 by R David Murray in branch 'default':
    whatsnew: inet_pton/inet_ntop support windows (bpo-7171).
    http://hg.python.org/cpython/rev/f82145a516f0

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants