Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initgroups to the posix/os modules #51582

Closed
exarkun mannequin opened this issue Nov 16, 2009 · 10 comments
Closed

Add initgroups to the posix/os modules #51582

exarkun mannequin opened this issue Nov 16, 2009 · 10 comments
Labels
stdlib Python modules in the Lib dir

Comments

@exarkun
Copy link
Mannequin

exarkun mannequin commented Nov 16, 2009

BPO 7333
Nosy @amauryfa, @pitrou, @pjenvey
Files
  • initgroups.patch
  • initgroups-2.patch
  • initgroups-3.patch
  • initgroups-4.patch
  • initgroups-5.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2009-12-02.20:47:25.344>
    created_at = <Date 2009-11-16.14:57:38.152>
    labels = ['library']
    title = 'Add initgroups to the posix/os modules'
    updated_at = <Date 2009-12-02.20:47:25.342>
    user = 'https://bugs.python.org/exarkun'

    bugs.python.org fields:

    activity = <Date 2009-12-02.20:47:25.342>
    actor = 'pitrou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2009-12-02.20:47:25.344>
    closer = 'pitrou'
    components = ['Library (Lib)']
    creation = <Date 2009-11-16.14:57:38.152>
    creator = 'exarkun'
    dependencies = []
    files = ['15345', '15347', '15353', '15354', '15440']
    hgrepos = []
    issue_num = 7333
    keywords = ['patch']
    message_count = 10.0
    messages = ['95348', '95359', '95362', '95363', '95371', '95384', '95385', '95905', '95909', '95917']
    nosy_count = 4.0
    nosy_names = ['exarkun', 'amaury.forgeotdarc', 'pitrou', 'pjenvey']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue7333'
    versions = ['Python 2.7']

    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Nov 16, 2009

    initgroups(2) is a function for initializing the aux group id list from
    site-specific configuration (typically /etc/groups, but not necessarily).

    Attached is a patch based on some code from Zope, expanded to have a
    test and some docs. Presumably Zope will be happy to use this function
    from the stdlib once they can depend on a version of Python which
    includes it. Twisted would like to as well.

    I wasn't able to test the autoconf related parts of the patch as I don't
    have easy access to autoconf 2.61.

    I also can't run regrtest.py in my environment for some reason. It
    fails to import some names from test_support. So I didn't run the unit
    test that I added, either.

    @exarkun exarkun mannequin added the stdlib Python modules in the Lib dir label Nov 16, 2009
    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Nov 16, 2009

    In case anyone is concerned about licensing issues, please see
    <https://mail.zope.org/pipermail/zope-dev/2009-November/038289.html\>

    @pjenvey
    Copy link
    Member

    pjenvey commented Nov 16, 2009

    The test should skip when not hasattr(os, 'initgroups') since it's
    optional

    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Nov 16, 2009

    Good point. Updated patch attached.

    @pitrou
    Copy link
    Member

    pitrou commented Nov 17, 2009

    You can use the new test-skipping feature:
    http://docs.python.org/dev/library/unittest.html#skipping-tests-and-expected-failures

    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Nov 17, 2009

    Alright. Updated patch attached.

    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Nov 17, 2009

    pyflakes told me I didn't import errno in test_posix.py. Updated patch
    attached.

    @amauryfa
    Copy link
    Contributor

    amauryfa commented Dec 2, 2009

    The documentation is os.rst is too laconic (coming from the Windows
    world, I could not understand what the function is about).
    The docstring is much better (at least I understand it's related to the
    Unix security model), I suggest to use it for the documentation.

    @exarkun
    Copy link
    Mannequin Author

    exarkun mannequin commented Dec 2, 2009

    New version attached which makes the os.rst docs the same as the
    docstring. Also fixes a conflict since introduced in trunk in configure.in.

    @pitrou
    Copy link
    Member

    pitrou commented Dec 2, 2009

    Slightly modified and committed in r76636 (trunk) and r76637 (py3k).
    Thank you.

    @pitrou pitrou closed this as completed Dec 2, 2009
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants