-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling SSL_MODE_AUTO_RETRY on SSL sockets #52469
Comments
In light of the recv() and recv_into() implementation change (bpo-3890), I think we should enable SSL_MODE_AUTO_RETRY for SSL sockets. It prevents blocking read() calls from getting SSL_ERROR_WANT_READ at all. See description in « SSL_MODE_AUTO_RETRY
|
By reading the doc it is not clear if we should activate this option only when dealing with blocking sockets. |
To me it looks clearly like a no-op ("Never bother the application with retries *if the transport is blocking*"). |
Mmm you're right. Sorry. |
Looks like a good idea. |
See also issue bpo-8240 about SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER (ssl.SSLSocket.write may fail on non-blocking sockets). |
+1 if it's more efficient ;-) |
Would it be possible to add an option to disable SSL_MODE_AUTO_RETRY for a specific socket? Existing applications may rely on / prefer the current behaviour. |
I don't think so, since recv() used to emulate that behaviour anyway. |
Fixed in r79448 (trunk), r79449 (py3k), r79451 (2.6), r79453 (3.1). |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: