-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out HTTP 0.9 client support #54920
Comments
Both http.client and http.server claim to support HTTP 0.9. The HTTP 1.0 RFC was filed in 1996, and 1.1 is most commonly used nowadays. We should probably rip off 0.9 support. |
Here is a patch. |
Would it be worth keeping (but modifying) test_http_0_9 to verify that the server complains in the expected way? |
Ripping HTTP "0.9" support _out_ flys directly in the face of "be lenient in what you accept and strict in what you produce." I do not mind removing support from http.server. But http.client needs to be able to communicate with any random server created since the dawn of time. Often on 8 bit microcontrollers that haven't been updated since 1994. How does keeping 0.9 client support in hurt us? |
At minimum, I think we should apply this part of Antoine's patch:
|
Well, that sounds a bit unreasonable...
Anyone with such needs should write specialized software, shouldn't they?
In any such situation, there's typically a long-term cost in additional maintenance when patching and improving the code. |
Actually, I don't think the server will complain, since the request is legit. It will send back a full response with status line and headers, though, so the test has to be adapted indeed. |
Patch with adapted tests. |
Given the 6961 issue I'm happy to change my position and say we nuke the 0.9 client support. Anyone who _needs_ that can grab this old code or write trivial code for their poor server's needs. |
+1 removing HTTP 0.9, and falling back to HTTP 1.0 behavior where ever it was HTTP 0.9. Removing support for response without status (which was acceptable by 0.9) is fine. I reviewed the patch too and it seems good to go. |
I'm opening a separate issue (bpo-10721) for the server side and retargetting this issue to client support. Patch attached. |
Patch LGTM, modulo warnings.warn calls lacking a stacklevel=2 parameter. |
Patch committed in r87340. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: