-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Add sethostname() #55075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This patch adds sethostname to the socket module (since socket has gethostname()). |
I'm not sure why you use PyTuple_Size() and PyTuple_GetItem(). |
Here is a simplified version. |
New patch including a check for PyObject_GetBuffer()'s return value, the missing declaration of HAVE_SETHOSTNAME in pyconfig.h.in, and a test for giving a bytes values to the function. |
The patch looks good. Just to be clear, on my system running "autoreconf" adds the correct stuff to pyconfig.h.in Isn't it best to leave it up to the committer to generate "configure" and "pyconfig.h.in", especially since different autoconf versions can create a lot of differences? |
Ah, strange. I used "autoconf" and it didn't...
Right, but in this case the version was the same and it was easier to |
From the man page of autoreconf: I guess it autoheader that regenerates pyconfig.h.in |
Patch committed in r88685 (3.3), closing. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: