Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regrtest.py doesn't check for unexpected output anymore? #56298

Closed
vstinner opened this issue May 16, 2011 · 5 comments
Closed

regrtest.py doesn't check for unexpected output anymore? #56298

vstinner opened this issue May 16, 2011 · 5 comments
Labels
tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented May 16, 2011

BPO 12089
Nosy @pitrou, @vstinner, @bitdancer

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-05-30.20:58:25.315>
created_at = <Date 2011-05-16.15:14:03.981>
labels = ['tests']
title = "regrtest.py doesn't check for unexpected output anymore?"
updated_at = <Date 2011-05-30.20:58:25.313>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2011-05-30.20:58:25.313>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2011-05-30.20:58:25.315>
closer = 'python-dev'
components = ['Tests']
creation = <Date 2011-05-16.15:14:03.981>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 12089
keywords = []
message_count = 5.0
messages = ['136103', '136113', '136733', '136735', '137327']
nosy_count = 5.0
nosy_names = ['pitrou', 'vstinner', 'Arfrever', 'r.david.murray', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue12089'
versions = ['Python 3.2', 'Python 3.3']

@vstinner
Copy link
Member Author

vstinner commented May 16, 2011

In Python 3.1, a test fails if it writes to stdout/stderr. It is no more the case in Python 3.2 and 3.3. Why? If we decided to not check for unexpected output in Python 3.2+, the following code should be removed:

    if verbose:
        capture_stdout = None
    else:
        capture_stdout = io.StringIO()

@vstinner vstinner added the tests Tests in the Lib/test dir label May 16, 2011
@bitdancer
Copy link
Member

bitdancer commented May 16, 2011

Antoine removed that check as part of the -j support, if I recall correctly. The check for unexpected output was part of the support for the transition between the old pre-unittest test suite and the unittest based test suite, and does seem like it is obsolete. Presumably we will visually spot unexpected output during pre-checkin testing.

@vstinner
Copy link
Member Author

vstinner commented May 24, 2011

@antoine: What's your opinion?

@pitrou
Copy link
Member

pitrou commented May 24, 2011

IMO this was all obsolete long ago, when we replaced stdout-based comparison of test results with proper assert* method calls.

@python-dev
Copy link
Mannequin

python-dev mannequin commented May 30, 2011

New changeset 6051f2c93163 by Victor Stinner in branch 'default':
Close bpo-12089: Remove outdated and unused code from regrtest.
http://hg.python.org/cpython/rev/6051f2c93163

@python-dev python-dev mannequin closed this as completed May 30, 2011
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

3 participants