Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCC command support to ftplib #56348

Closed
giampaolo opened this issue May 21, 2011 · 10 comments
Closed

Add CCC command support to ftplib #56348

giampaolo opened this issue May 21, 2011 · 10 comments
Assignees
Labels
type-feature A feature request or enhancement

Comments

@giampaolo
Copy link
Contributor

giampaolo commented May 21, 2011

BPO 12139
Nosy @pitrou, @vstinner, @giampaolo
Files
  • ftplib-ccc.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/giampaolo'
    closed_at = <Date 2011-06-30.16:36:03.170>
    created_at = <Date 2011-05-21.18:09:00.154>
    labels = ['type-feature']
    title = 'Add CCC command support to ftplib'
    updated_at = <Date 2011-06-30.16:36:03.169>
    user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2011-06-30.16:36:03.169>
    actor = 'giampaolo.rodola'
    assignee = 'giampaolo.rodola'
    closed = True
    closed_date = <Date 2011-06-30.16:36:03.170>
    closer = 'giampaolo.rodola'
    components = []
    creation = <Date 2011-05-21.18:09:00.154>
    creator = 'giampaolo.rodola'
    dependencies = []
    files = ['22052']
    hgrepos = []
    issue_num = 12139
    keywords = ['patch']
    message_count = 10.0
    messages = ['136459', '136463', '136465', '139250', '139252', '139253', '139254', '139493', '139499', '139501']
    nosy_count = 4.0
    nosy_names = ['pitrou', 'vstinner', 'giampaolo.rodola', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue12139'
    versions = ['Python 3.3']

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented May 21, 2011

    In FTPS, CCC command can be used to switch back to a clear-text control connection.
    This can be useful to take advantage of firewalls that know how to handle NAT with non-secure FTP without opening fixed ports.
    Patch in attachment includes lib, test and doc changes.

    @giampaolo giampaolo self-assigned this May 21, 2011
    @giampaolo giampaolo added the type-feature A feature request or enhancement label May 21, 2011
    @pitrou
    Copy link
    Member

    pitrou commented May 21, 2011

    This can be useful to take advantage of firewalls that know how to
    handle NAT with non-secure FTP without opening fixed ports.

    Can you explain this a little more?

    + resp = self.voidcmd('CCC')
    + self.sock = self.sock.unwrap()
    + return resp

    Should the response be checked before calling unwrap()?

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented May 21, 2011

    voidcmd() expects a response code starting with "2" and automatically raises an exception otherwise.
    A server succesfully accepting the CCC command is supposed to first reply with 220 and then shutdown() the SSL layer.
    Client is supposed to do the same: first receive the 2xx response and then make the shutdown().

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 27, 2011

    New changeset d2eacbbdaf57 by Giampaolo Rodola' in branch 'default':
    bpo-12139: add CCC command support to FTP_TLS class to revert the SSL connection back to clear-text.
    http://hg.python.org/cpython/rev/d2eacbbdaf57

    @vstinner
    Copy link
    Member

    vstinner commented Jun 27, 2011

    http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/4043/steps/test/logs/stdio

    ======================================================================
    ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 890, in test_ccc
        self.client.sendcmd('noop')
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/ftplib.py", line 261, in sendcmd
        return self.getresp()
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/ftplib.py", line 236, in getresp
        raise error_proto(resp)
    ftplib.error_proto: ��� Ôxéî¢��Ö®�º¸qh�Ñ�øcÞ�Å\³9úÓ�#ï�å200 noop ok

    @vstinner
    Copy link
    Member

    vstinner commented Jun 27, 2011

    http://www.python.org/dev/buildbot/all/builders/x86%20Tiger%203.x/builds/2792/steps/test/logs/stdio

    ======================================================================
    ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/test_ftplib.py", line 890, in test_ccc
        self.client.sendcmd('noop')
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/ftplib.py", line 261, in sendcmd
        return self.getresp()
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/ftplib.py", line 226, in getresp
        resp = self.getmultiline()
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/ftplib.py", line 212, in getmultiline
        line = self.getline()
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/ftplib.py", line 199, in getline
        line = self.file.readline()
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/socket.py", line 279, in readinto
        return self._sock.recv_into(b)
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/ssl.py", line 392, in recv_into
        return socket.recv_into(self, buffer, nbytes, flags)
    socket.timeout: timed out

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented Jun 27, 2011

    Hmm... Reopening. I'll look into this later.

    @giampaolo giampaolo reopened this Jun 27, 2011
    @vstinner
    Copy link
    Member

    vstinner commented Jun 30, 2011

    The test is still failing on many buildbots.

    x86 Ubuntu Shared 3.x:

    ======================================================================
    ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 890, in test_ccc
        self.client.sendcmd('noop')
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/ftplib.py", line 261, in sendcmd
        return self.getresp()
      File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/ftplib.py", line 236, in getresp
        raise error_proto(resp)
    ftplib.error_proto: ��� �eÊc¯�öZÖ8N´��ýùô

    "PPC Tiger 3.x", "AMD64 Leopard 3.x", "x86 FreeBSD 6.4 3.x" and "x86 Tiger 3.x":

    ======================================================================
    ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/test/test_ftplib.py", line 890, in test_ccc
        self.client.sendcmd('noop')
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/ftplib.py", line 261, in sendcmd
        return self.getresp()
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/ftplib.py", line 226, in getresp
        resp = self.getmultiline()
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/ftplib.py", line 212, in getmultiline
        line = self.getline()
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/ftplib.py", line 199, in getline
        line = self.file.readline()
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/socket.py", line 279, in readinto
        return self._sock.recv_into(b)
      File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86-2/build/Lib/ssl.py", line 392, in recv_into
        return socket.recv_into(self, buffer, nbytes, flags)
    socket.timeout: timed out

    @giampaolo
    Copy link
    Contributor Author

    giampaolo commented Jun 30, 2011

    The culprit here is the dummy FTP test server which does not complete the SSL shutdown procedure successfully.

    I believe it's better if we remove the self.client.sendcmd('noop') line.

    That's there in order to check that client and server can still "talk" after reverting the connection back to clear-text, but making the server doing this right is quite complicated, see for example:
    http://code.google.com/p/pyftpdlib/source/browse/trunk/pyftpdlib/contrib/handlers.py?spec=svn868&r=861#196

    I don't want to include and maintain that monster into test_ftplib.py so I think I'll just remove that line from the tests.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 30, 2011

    New changeset 0cef8cac71c8 by Giampaolo Rodola' in branch 'default':
    bpo-12139: ftplib - remove 'post CCC' test to fix various buildot failures due to dummy test server not properly handling SSL shutdown(), see http://bugs.python.org/msg139499
    http://hg.python.org/cpython/rev/0cef8cac71c8

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants