Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_collectionsmodule.c: refleak #57224

Closed
SumanSaha mannequin opened this issue Sep 20, 2011 · 4 comments
Closed

_collectionsmodule.c: refleak #57224

SumanSaha mannequin opened this issue Sep 20, 2011 · 4 comments
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@SumanSaha
Copy link
Mannequin

SumanSaha mannequin commented Sep 20, 2011

BPO 13015
Nosy @birkenfeld, @pitrou
Files
  • python_patch3: Patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-02-15.01:51:46.618>
    created_at = <Date 2011-09-20.14:53:25.629>
    labels = ['extension-modules', 'performance']
    title = '_collectionsmodule.c: refleak'
    updated_at = <Date 2012-02-15.01:51:46.595>
    user = 'https://bugs.python.org/SumanSaha'

    bugs.python.org fields:

    activity = <Date 2012-02-15.01:51:46.595>
    actor = 'pitrou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2012-02-15.01:51:46.618>
    closer = 'pitrou'
    components = ['Extension Modules']
    creation = <Date 2011-09-20.14:53:25.629>
    creator = 'Suman.Saha'
    dependencies = []
    files = ['23200']
    hgrepos = []
    issue_num = 13015
    keywords = []
    message_count = 4.0
    messages = ['144332', '144495', '153385', '153386']
    nosy_count = 4.0
    nosy_names = ['georg.brandl', 'pitrou', 'python-dev', 'Suman.Saha']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue13015'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    @SumanSaha
    Copy link
    Mannequin Author

    SumanSaha mannequin commented Sep 20, 2011

    Something that is allocated using PyDict_Type.tp_repr is not freed on one error path.

    @SumanSaha SumanSaha mannequin added the performance Performance or resource usage label Sep 20, 2011
    @skrah skrah mannequin added the extension-modules C modules in the Modules dir label Sep 21, 2011
    @skrah skrah mannequin changed the title Resource is not released before returning from the functiion _collectionsmodule.c: refleak Sep 21, 2011
    @birkenfeld
    Copy link
    Member

    Looks correct but awkwardly indented.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 15, 2012

    New changeset 86adb5c7a9d4 by Antoine Pitrou in branch '3.2':
    Issue bpo-13015: Fix a possible reference leak in defaultdict.__repr__.
    http://hg.python.org/cpython/rev/86adb5c7a9d4

    New changeset 7cfce717ceee by Antoine Pitrou in branch 'default':
    Issue bpo-13015: Fix a possible reference leak in defaultdict.__repr__.
    http://hg.python.org/cpython/rev/7cfce717ceee

    New changeset 7611fb3e19c6 by Antoine Pitrou in branch '2.7':
    Issue bpo-13015: Fix a possible reference leak in defaultdict.__repr__.
    http://hg.python.org/cpython/rev/7611fb3e19c6

    @pitrou
    Copy link
    Member

    pitrou commented Feb 15, 2012

    Patch now committed, thank you!

    @pitrou pitrou closed this as completed Feb 15, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants