Skip to content

Conversation

@scoder
Copy link
Contributor

@scoder scoder commented Feb 17, 2018

@ruffsl
Copy link

ruffsl commented Feb 19, 2018

I like the new configurable base_url!

As mentioned in this message from the originating issue, would it at all be possible to add the xml:base attribute to elements included from locations with a different base URI, as to comply with the XInclude standard? Just tested bc8bfc2, and this still seems to be missing.

@scoder scoder force-pushed the etree_xinclude branch 2 times, most recently from 448d126 to 4d53056 Compare February 23, 2018 17:45
@scoder
Copy link
Contributor Author

scoder commented Mar 30, 2018

Added news entry, rebased to latest (3.8) master.

@scoder
Copy link
Contributor Author

scoder commented Mar 30, 2018

Lacks a documentation update, because there is no documentation for the overall ElementInclude feature in CPython. I created issue 33187 for this. When someone writes documentation, this addition is easy to include there.

@scoder
Copy link
Contributor Author

scoder commented Apr 14, 2019

One remaining issue: how can users disable recursive include processing if they want to?

@scoder scoder closed this Sep 10, 2019
@scoder scoder reopened this Sep 10, 2019
@scoder scoder merged commit c6a7bdb into python:master Nov 25, 2019
@scoder scoder deleted the etree_xinclude branch November 25, 2019 15:36
@bedevere-bot
Copy link

@scoder: Please replace # with GH- in the commit message next time. Thanks!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
…clude (python#5723)

* bpo-20928: bring elementtree's XInclude support en-par with the implementation in lxml by adding support for recursive includes and a base-URL.

* bpo-20928: Support xincluding the same file multiple times, just not recursively.

* bpo-20928: Add 'max_depth' parameter to xinclude that limits the maximum recursion depth to 6 by default.

* Add news entry for updated ElementInclude support
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…clude (python#5723)

* bpo-20928: bring elementtree's XInclude support en-par with the implementation in lxml by adding support for recursive includes and a base-URL.

* bpo-20928: Support xincluding the same file multiple times, just not recursively.

* bpo-20928: Add 'max_depth' parameter to xinclude that limits the maximum recursion depth to 6 by default.

* Add news entry for updated ElementInclude support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants