deprecated in 3.2/3.3, should be removed in 3.5 or ???

[florentx]

BPO	13248
Nosy	@rhettinger, @terryjreedy, @orsenthil, @pitrou, @vstinner, @larryhastings, @giampaolo, @tiran, @ezio-melotti, @merwok, @florentx, @berkerpeksag, @vadmium, @1st1
Files	issue13248_obsolescence_v3.diff issue13248.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-05-19.18:40:32.173>
created_at = <Date 2011-10-23.17:49:46.072>
labels = ['type-bug', 'library']
title = 'deprecated in 3.2/3.3, should be removed in 3.5 or ???'
updated_at = <Date 2020-05-19.18:40:32.172>
user = 'https://github.com/florentx'

bugs.python.org fields:

activity = <Date 2020-05-19.18:40:32.172>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-19.18:40:32.173>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2011-10-23.17:49:46.072>
creator = 'flox'
dependencies = []
files = ['26301', '32662']
hgrepos = []
issue_num = 13248
keywords = ['patch']
message_count = 49.0
messages = ['146236', '146237', '146259', '146284', '146288', '146289', '146344', '146500', '146581', '149145', '149192', '149265', '149297', '149301', '149320', '149322', '155797', '155815', '155836', '155838', '155839', '155841', '164850', '164852', '164865', '164880', '164901', '164924', '164979', '184706', '184925', '185120', '185123', '203111', '217452', '217457', '221491', '233278', '233293', '233296', '233297', '233434', '233444', '247207', '247209', '247689', '247720', '247727', '275206']
nosy_count = 18.0
nosy_names = ['rhettinger', 'terry.reedy', 'orsenthil', 'pitrou', 'vstinner', 'larry', 'giampaolo.rodola', 'christian.heimes', 'ezio.melotti', 'eric.araujo', 'Arfrever', 'flox', 'Yaroslav.Halchenko', 'tshepang', 'python-dev', 'berker.peksag', 'martin.panter', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue13248'
versions = ['Python 3.5']

[florentx]

The PEP-387 suggests that deprecated objects or arguments are removed in version (n+1).
I've listed these DeprecationWarnings in 3.2, which are still in 3.3.
I assume that most of these deprecated objects or arguments could be removed before next release.

*_pyio*
argument "max_buffer_size" of BufferedWriter and BufferedRWPair
*argparse*
argument "version" and related methods of ArgumentParser
*asyncore*
shortcut "dispatcher.*" for "dispatcher.socket.*" attributes
*base64*
functions "encodestring" and "decodestring"
*cgi*
functions "parse_qs" and "parse_qsl"
*configparser*
"ParsingError.filename", "RawConfigParser.readfp", "SafeConfigParser"
*decimal*
"Context._clamp"
*difflib*
"SequenceMatcher.isbjunk", "SequenceMatcher.isbpopular"
*gzip*
"GzipFile.filename"
*http.client*
argument "strict" of HTTPResponse and HTTPConnection
*lib2to3*
methods "set_prefix" and "get_prefix" of "pytree.Base"
*mailbox*
argument of type "StringIO" or "text mode files"
*ntpath*
function "splitunc"
*tarfile*
argument "exclude" of "TarFile.add"
*trace*
old API
*unittest*
"assert{DictContainsSubset,RaisesRegexp,RegexpMatches}", "fail*"
*xml.etree*
"Element.getchildren", "XMLParser.doctype"

[florentx]

In addition, we have some object and attributes which are triggering "PendingDeprecationWarning" in 3.2.
We may keep these warnings in 3.3, or choose to turn some of them into "DeprecationWarning", to prepare their removal in 3.5.

*cgi*
"cgi.escape"
*distutils"
argument compress="compress" of make_tarball
function "check_metadata" in "command.register"
option "force-manifest" of "command.sdist"
*importlib*
"abc.PyLoader" and "abc.PyPycLoader"
*nntplib*
"_NNTPBase.xgtitle" and "_NNTPBase.xpath"
*smtpd*
the class-private "__" attributes
*xml.etree
method "getiterator" of "Element" and "ElementTree"

[ezio-melotti]

*unittest*
"assert{DictContainsSubset,RaisesRegexp,RegexpMatches}", "fail*"

The "fail*" should stay.

The general idea is that with Python3 we can wait a bit more before getting rid of things, because if someone jumps from 2.7 to 3.3, he might not find things that got deprecated in 3.2 and disappeared on 3.3.

That said, some of the more obscure functions/method/attributes can probably go.

Also I think that PendingDeprecations are now quite useless, since DeprecationWarnings are silenced by default. I think we can convert them to DeprecationWarnings, even if we leave them there for a couple of versions.

[python-dev]

New changeset 221638ba5d2a by Mark Dickinson in branch 'default':
Issue bpo-13248, issue bpo-8540: Remove deprecated Context._clamp attribute from Decimal module.
http://hg.python.org/cpython/rev/221638ba5d2a

[florentx]

I missed these warnings in C modules.

*array*
"fromstring" and "tostring" methods
*io* (like _pyio)
argument "max_buffer_size" of BufferedWriter and BufferedRWPair
*sys*
"sys.getcheckinterval" and "sys.setcheckinterval"

and some complaints from Objects/typeobject.c:

"object.__init__() takes no parameters"
"object.__new__() takes no parameters"
"object.__format__ with a non-empty format string is deprecated"
"Type %.100s defines tp_reserved (formerly tp_compare) but not "
"tp_richcompare. Comparisons may not behave as intended."

[pitrou]

*array*
"fromstring" and "tostring" methods

I think these ones (and other well-known 2.x methods) should be kept to ease porting to 3.x.

[ezio-melotti]

Maybe a 2to3 fixer to convert the names should be added?

[merwok]

distutils will not change. I’ll ask if removing the deprecation warnings is okay, otherwise they’ll stay.

For ConfigParser.readfp, it would ease porting between 2.x and 3.x if the method could stay longer, or forever.

[terryjreedy]

The difflib deprecations are mine and I think they should happen in 3.3.
This will serve as a reminder.

[python-dev]

New changeset f82ebf9b3a52 by Florent Xicluna in branch 'default':
Issue bpo-13248: turn 3.2's PendingDeprecationWarning into 3.3's DeprecationWarning (cgi, importlib, nntplib, smtpd).
http://hg.python.org/cpython/rev/f82ebf9b3a52

[florentx]

I know it won't be committed as-is, but this is the patch with most of the deprecated things removed.

I skipped all the modules where a veto has been pronounced explicitly.

[vstinner]

.. versionchanged:: 3.2
-      The *strict* parameter is deprecated.  HTTP 0.9-style "Simple Responses"
+      The *strict* parameter is removed.  HTTP 0.9-style "Simple Responses"
       are not supported anymore.

Such change looks wrong: the parameter exists in Python 3.2.

[pitrou]

I think most of these shouldn't be removed, as it would make porting from 2.x significantly more tedious.

Things that I think can be removed:

• max_buffer_size (io is new and that argument was never used by anybody)
• get_prefix / set_prefix (the internal lib2to3 API is not documented AFAICT)
• the argparse things (argparse is new)