Remove deprecated tkinter functions

[asvetlov]

BPO	14446
Nosy	@jcea, @bitdancer, @asvetlov
Files	tkinter.patch: tkinter patch tkinter_doc.patch: tkinter doc patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/asvetlov'
closed_at = <Date 2012-10-04.19:13:28.049>
created_at = <Date 2012-03-29.19:57:49.322>
labels = ['easy', 'deferred-blocker', 'type-feature', 'expert-tkinter']
title = 'Remove deprecated tkinter functions'
updated_at = <Date 2012-10-05.02:03:14.770>
user = 'https://github.com/asvetlov'

bugs.python.org fields:

activity = <Date 2012-10-05.02:03:14.770>
actor = 'python-dev'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2012-10-04.19:13:28.049>
closer = 'asvetlov'
components = ['Tkinter']
creation = <Date 2012-03-29.19:57:49.322>
creator = 'asvetlov'
dependencies = []
files = ['25793', '25799']
hgrepos = []
issue_num = 14446
keywords = ['patch', 'easy']
message_count = 14.0
messages = ['157091', '157195', '157203', '162108', '162109', '162112', '162141', '162637', '162647', '171987', '171988', '172040', '172041', '172042']
nosy_count = 5.0
nosy_names = ['jcea', 'r.david.murray', 'asvetlov', 'python-dev', 'michael.driscoll']
pr_nums = []
priority = 'deferred blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14446'
versions = ['Python 3.4']

[asvetlov]

We need to remove deprecated tkinter.AtEnd and family in 3.4

[asvetlov]

See issue bpo-3035 for details.

[asvetlov]

Also see bpo-5136 for deprecated C Functions from _tkinter.c
That set have to go away in 3.4 as well as deprecations from tkinter/init.py

[michaeldriscoll]

After reading up on both issues, I think I found all the instances that were deprecated and removed them. A patch is attached that includes the edits for tkinter/init.py and the _tkinter.c files.

[michaeldriscoll]

I just noticed that we'll need to update the Documentation for tkinter too as it mentions the AtEnd etc methods. Do you want me to create a patch for that or a new ticket + patch?

[bitdancer]

The doc changes should be part of the patch. I forget, though, if we completely delete deprecated stuff from the docs or if we keep a deprecation stub in place.

Note that it is possible (although in this case probably not too likely) that the code will drift before 3.4 and the patch need to be regenerated.

[michaeldriscoll]

Here's the doc patch. The local repo I was using yesterday is on a different computer that I don't have access to today. Hopefully applying two patches is okay. If not, I can redo the other patch and add it to this one.

[michaeldriscoll]

Do I need to do anything else to those patches I submitted?

[asvetlov]

Michael Driscoll, thank you for patch.
Let's go on after Python 3.3 release — those patches should be applied for 3.4.
For now we need to wait.

[python-dev]

New changeset 83da5729e362 by Andrew Svetlov in branch 'default':
Issue bpo-14446: Remove deprecated tkinter functions
http://hg.python.org/cpython/rev/83da5729e362

[asvetlov]

Thanks to Michael Driscoll.
BTW you have forgotten to remove C functions from module definition in your patch.

[jcea]

I am getting a warning about a statically defined function not being used:

<http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/4680/steps/compile/logs/warnings%20%283%29\>

Static functions not called inside the module can be safely deleted. In this case, "Merge".

[python-dev]

New changeset f4f45d8ff785 by Jesus Cea in branch 'default':
Issue bpo-14446: Remove deprecated tkinter functions: Delete an unused function to avoid a warning
http://hg.python.org/cpython/rev/f4f45d8ff785

[python-dev]

New changeset e278f3ab0190 by Jesus Cea in branch 'default':
Issue bpo-14446: Remove deprecated tkinter functions: Delete an unused function to avoid a warning
http://hg.python.org/cpython/rev/e278f3ab0190