Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using of w9xopen in subprocess module #58675

Closed
asvetlov opened this issue Apr 1, 2012 · 9 comments
Closed

Remove using of w9xopen in subprocess module #58675

asvetlov opened this issue Apr 1, 2012 · 9 comments
Assignees
Labels
easy OS-windows stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Apr 1, 2012

BPO 14470
Nosy @pitrou, @merwok, @briancurtin, @asvetlov
Files
  • subprocess_minus_w9xpopen.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/briancurtin'
    closed_at = <Date 2012-12-23.22:57:54.765>
    created_at = <Date 2012-04-01.18:06:26.453>
    labels = ['easy', 'type-feature', 'library', 'OS-windows']
    title = 'Remove using of w9xopen in subprocess module'
    updated_at = <Date 2013-01-08.12:32:11.922>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2013-01-08.12:32:11.922>
    actor = 'eric.araujo'
    assignee = 'brian.curtin'
    closed = True
    closed_date = <Date 2012-12-23.22:57:54.765>
    closer = 'brian.curtin'
    components = ['Library (Lib)', 'Windows']
    creation = <Date 2012-04-01.18:06:26.453>
    creator = 'asvetlov'
    dependencies = []
    files = ['25296']
    hgrepos = []
    issue_num = 14470
    keywords = ['patch', 'easy']
    message_count = 9.0
    messages = ['157321', '157443', '158898', '160869', '160871', '178019', '178074', '178075', '179345']
    nosy_count = 6.0
    nosy_names = ['pitrou', 'eric.araujo', 'brian.curtin', 'asvetlov', 'python-dev', 'Rune']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue14470'
    versions = ['Python 3.4']

    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Apr 1, 2012

    As Python 3.3 declare:
    Windows 2000 and Windows platforms which set COMSPEC to command.com are no longer supported due to maintenance burden.

    We need to drop corresponding code from subprocess.

    @asvetlov asvetlov added easy type-feature A feature request or enhancement stdlib Python modules in the Lib dir OS-windows labels Apr 1, 2012
    @asvetlov asvetlov changed the title Remove use of w9xopen in subporcess module Remove using of w9xopen in subporcess module Apr 1, 2012
    @ned-deily ned-deily changed the title Remove using of w9xopen in subporcess module Remove using of w9xopen in subprocess module Apr 1, 2012
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Apr 3, 2012

    Brian, please don't forget to cleanup subprocess code when you will be ready to.

    @Rune
    Copy link
    Mannequin

    Rune mannequin commented Apr 20, 2012

    Removed w9xpopen usage in subprocess module via attached patch.

    @pitrou
    Copy link
    Member

    pitrou commented May 16, 2012

    Brian, is the patch ok?

    @briancurtin
    Copy link
    Member

    briancurtin commented May 16, 2012

    Hm, I thought I already responded to this one. PEP-11 states that the w9xpopen code shouldn't be removed until 3.4. I have a patch on another computer that adds a deprecation for 3.3 - I'll add it here within the day.

    For 3.4 we would actually remove the w9xpopen project from the VS solution and make sure it's no longer a part of the project.

    http://www.python.org/dev/peps/pep-0011/

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 23, 2012

    New changeset c903e4f1121d by Brian Curtin in branch 'default':
    Fix bpo-14470. Remove w9xpopen per PEP-11.
    http://hg.python.org/cpython/rev/c903e4f1121d

    New changeset ae1845e4006a by Brian Curtin in branch 'default':
    Add NEWS item for fixing bpo-14470.
    http://hg.python.org/cpython/rev/ae1845e4006a

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 24, 2012

    New changeset deee9f0a4b98 by Brian Curtin in branch 'default':
    Fix bpo-14470. Remove mentions of w9xpopen on old versions of Visual Studio.
    http://hg.python.org/cpython/rev/deee9f0a4b98

    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Dec 24, 2012

    Thanks

    On Mon, Dec 24, 2012 at 6:44 PM, Roundup Robot <report@bugs.python.org> wrote:

    Roundup Robot added the comment:

    New changeset deee9f0a4b98 by Brian Curtin in branch 'default':
    Fix bpo-14470. Remove mentions of w9xpopen on old versions of Visual Studio.
    http://hg.python.org/cpython/rev/deee9f0a4b98

    ----------


    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue14470\>


    @merwok
    Copy link
    Member

    merwok commented Jan 8, 2013

    FTR, was the deprecation for 3.3 committed?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy OS-windows stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants