lll.py can't handle multiple parameters correctly

[carton]

BPO	14546
Nosy	@vstinner, @bitdancer, @serhiy-storchaka, @ZackerySpytz
PRs	bpo-14546: Fix the argument handling in Tools/scripts/lll.py #13026 [3.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) #13060 [2.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) #13063
Files	lll.py.patch: Patch file

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-05-02.19:30:04.230>
created_at = <Date 2012-04-11.14:29:36.219>
labels = ['3.8', 'type-bug', '3.7']
title = "lll.py can't handle multiple parameters correctly"
updated_at = <Date 2019-05-02.19:30:04.229>
user = 'https://bugs.python.org/carton'

bugs.python.org fields:

activity = <Date 2019-05-02.19:30:04.229>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-02.19:30:04.230>
closer = 'vstinner'
components = ['Demos and Tools']
creation = <Date 2012-04-11.14:29:36.219>
creator = 'carton'
dependencies = []
files = ['25178']
hgrepos = []
issue_num = 14546
keywords = ['patch']
message_count = 9.0
messages = ['158036', '158037', '341161', '341269', '341275', '341276', '341308', '341309', '341310']
nosy_count = 5.0
nosy_names = ['vstinner', 'r.david.murray', 'serhiy.storchaka', 'carton', 'ZackerySpytz']
pr_nums = ['13026', '13060', '13063']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14546'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']

[carton]

Space errors in calling of lll(arg) of main() cause it only applies to the last parameter instead of all parameters.

Patch attached for Python 3.1

[bitdancer]

Thanks for the patch.

Do you have any interest in writing a test for this? Tests for tools go in Lib/test/test_tools.py.

[ZackerySpytz]

I've created a PR for this issue (with a test).

[serhiy-storchaka]

New changeset c4e78b1 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026)
c4e78b1

[vstinner]

test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776.

[vstinner]

test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776.

I guess that the test should be decorated by @support.skip_unless_symlink or something like that.

[vstinner]

New changeset e85ba1e by Victor Stinner (Miss Islington (bot)) in branch '3.7':
[3.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13060)
e85ba1e

[vstinner]

New changeset 7c2c01f by Victor Stinner (Zackery Spytz) in branch '2.7':
[2.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13063)
7c2c01f

[vstinner]

Thanks Carton He for the bug report, thanks Zackery Spytz for the fix, thanks Serhiy Storchaka for the review ;-)