-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate strict mode of HTMLParser #59319
Comments
The deprecation plan for the strict mode of HTMLParser might be as follow: 3.3 (before the beta) 3.4 3.5 Everything that is parsed by strict=True is parsed by strict=False too, so changing the default shouldn't be a problem. The difference is that strict=False won't raise any error and will parse broken markup too. Given that no errors are raised HTMLParseError and HTMLParser.error become useless and can be deprecated (3.3) and removed (3.5) too. |
Your plan sounds fine to me. |
The attached patch include these changes:
Regarding
[0] I made a mistake in my first message: some of the calls should actually be converted to assert, the others will stay as long as the strict mode exists (i.e. they will be removed in 3.5) |
Why not deprecate .error()? Removing it immediately as undocumented is certainly not better. Otherwise sounds good, please commit. |
Regarding .error() I think the best thing to do is wait till 3.4 and then deprecate it. |
New changeset 8dd2f5754b2f by Ezio Melotti in branch 'default': |
3.3 is done. 3.4 3.5 |
New changeset 0a56709eb798 by Ezio Melotti in branch 'default': |
3.4 is done. 3.5 |
New changeset 0e2e47c1f205 by Ezio Melotti in branch 'default': |
3.5 is done. |
New changeset 5b95f3fdcc0b by Ezio Melotti in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: