Sockets support for CAN_BCM

[Thorney]

BPO	15359
Nosy	@pitrou
Files	python_bcm.patch: Diff against 78110:ba264b26d8d9 bcm2.patch: Diff against 81536:3fa3e7975724 bcm3.patch bcm4.patch: Diff against 81667:9a0cd5363c2a

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-02-05.19:38:42.755>
created_at = <Date 2012-07-15.13:10:55.436>
labels = ['type-feature', 'library']
title = 'Sockets support for CAN_BCM'
updated_at = <Date 2013-02-05.19:38:42.753>
user = 'https://bugs.python.org/Thorney'

bugs.python.org fields:

activity = <Date 2013-02-05.19:38:42.753>
actor = 'neologix'
assignee = 'none'
closed = True
closed_date = <Date 2013-02-05.19:38:42.755>
closer = 'neologix'
components = ['Library (Lib)']
creation = <Date 2012-07-15.13:10:55.436>
creator = 'Thorney'
dependencies = []
files = ['26386', '28747', '28756', '28805']
hgrepos = []
issue_num = 15359
keywords = ['patch']
message_count = 9.0
messages = ['165527', '165564', '179030', '180070', '180118', '180444', '180671', '181466', '181472']
nosy_count = 5.0
nosy_names = ['pitrou', 'Thorney', 'neologix', 'tshepang', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue15359'
versions = ['Python 3.4']

[Thorney]

In addition to CAN_RAW introduced in Python 3.3, it would be really useful to expose the CAN_BCM protocol. Effectively it hands off as much to the kernel as possible which gives Python programs the ability to send and receive many periodic messages with little additional jitter or overhead.

I've attached an early stab at a patch to see if there is interest.

I'll be putting more examples of using BCM sockets at https://bitbucket.org/hardbyte/python-socket-examples

[Thorney]

Once I've got more complete examples, I can update the patch to include a testcase.

[neologix]

Brian, could you add tests to Lib/test/test_socket.py (look for CANTest, you should be able to complete them).

[Thorney]

I've added a single BCM test. Any feedback on it would be good and then I'll add more complex ones.

Should the documentation be updated in this patch as well?

[Thorney]

Thanks for the review Charles-François.
I can't make your suggested bcm_msg_fmt work - it was deadlocking on my machine!

[Thorney]

I've added (some) docs and added checking of the BCM constants to the test_socket module.

I would guess that checking each broadcast manager function provided by the kernel isn't required?

[neologix]

I've added (some) docs and added checking of the BCM constants to the test_socket module.

This version looks good to me.
I'll commit it next week (I currently don't have access to my
development machine).

I would guess that checking each broadcast manager function provided by the kernel isn't required?

No, the goal is not to test the kernel implementation. That should be
enough for now.

[python-dev]

New changeset f714af60508d by Charles-François Natali in branch 'default':
Issue bpo-15359: Add CAN_BCM protocol support to the socket module. Patch by Brian
http://hg.python.org/cpython/rev/f714af60508d

[neologix]

Committed.
Brian, thanks for the patch!