Fix is/== misuse

[serhiy-storchaka]

BPO	16172
Nosy	@benjaminp, @ezio-melotti, @serhiy-storchaka
Files	is_int_or_str.patch equals_none_or_bool.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-10-09.15:17:48.242>
created_at = <Date 2012-10-09.09:54:54.815>
labels = ['type-feature', 'tests']
title = 'Fix is/== misuse'
updated_at = <Date 2012-10-09.15:17:48.238>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2012-10-09.15:17:48.238>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2012-10-09.15:17:48.242>
closer = 'benjamin.peterson'
components = ['Tests']
creation = <Date 2012-10-09.09:54:54.815>
creator = 'serhiy.storchaka'
dependencies = []
files = ['27503', '27504']
hgrepos = []
issue_num = 16172
keywords = ['patch']
message_count = 3.0
messages = ['172467', '172485', '172486']
nosy_count = 4.0
nosy_names = ['benjamin.peterson', 'ezio.melotti', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16172'
versions = ['Python 3.4']

[serhiy-storchaka]

Here are two patches written on the discussion in Python-Ideas [1].

The first patch fixes incorrect use of "x is 0" or "x is 'foo'". Result of this operations is implementation details.

The second patch changes non-idiomatic use of "x == None" or "x == True".

[1] http://comments.gmane.org/gmane.comp.python.ideas/16547

[python-dev]

New changeset 842276ae4a3f by Benjamin Peterson in branch '3.3':
compare with equality not identity (issue bpo-16172)
http://hg.python.org/cpython/rev/842276ae4a3f

[benjaminp]

Also http://hg.python.org/cpython/rev/332b93ce7bf9