Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xz compression in distutils #60518

Closed
serhiy-storchaka opened this issue Oct 24, 2012 · 13 comments
Closed

Support xz compression in distutils #60518

serhiy-storchaka opened this issue Oct 24, 2012 · 13 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 24, 2012

BPO 16314
Nosy @tarekziade, @jwilk, @ned-deily, @merwok, @serhiy-storchaka
Files
  • distutils-lzma.patch
  • distutils-lzma_2.patch
  • distutils-lzma_3.patch
  • distutils-lzma_4.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/merwok'
    closed_at = <Date 2015-05-19.11:13:53.289>
    created_at = <Date 2012-10-24.21:32:58.586>
    labels = ['type-feature', 'library']
    title = 'Support xz compression in distutils'
    updated_at = <Date 2015-05-19.11:13:53.288>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-05-19.11:13:53.288>
    actor = 'serhiy.storchaka'
    assignee = 'eric.araujo'
    closed = True
    closed_date = <Date 2015-05-19.11:13:53.289>
    closer = 'serhiy.storchaka'
    components = ['Distutils']
    creation = <Date 2012-10-24.21:32:58.586>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['27704', '38564', '38648', '38887']
    hgrepos = []
    issue_num = 16314
    keywords = ['patch', 'needs review']
    message_count = 13.0
    messages = ['173708', '173709', '173714', '210790', '224472', '238527', '238539', '238991', '240256', '240411', '243361', '243377', '243378']
    nosy_count = 8.0
    nosy_names = ['nadeem.vawda', 'tarek', 'jwilk', 'ned.deily', 'eric.araujo', 'Arfrever', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue16314'
    versions = ['Python 3.5']

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Oct 24, 2012

    The proposed patch adds xz compression support in additional to gzip, compress and bzip2 in distutils.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 24, 2012
    @merwok
    Copy link
    Member

    merwok commented Oct 24, 2012

    I think there’s already a report for distutils2.

    For distutils, if we take the feature freeze seriously, this would have to be rejected. I know it looks innocuous, but distutils is brittle code widely monkey-patched, so I prefer to take no chances.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Oct 24, 2012

    OK, I didn't know that distutils are frozen.

    @Arfrever
    Copy link
    Mannequin

    Arfrever mannequin commented Feb 9, 2014

    AFAIK distutils is no longer frozen.

    @Arfrever Arfrever mannequin reopened this Feb 9, 2014
    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Aug 1, 2014

    What about the patch?

    @merwok
    Copy link
    Member

    merwok commented Mar 19, 2015

    Code and doc changes look good. Will you add tests?

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 19, 2015

    Added tests for gztar, bztar and xztar. Added more asserts in other tests.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 23, 2015

    Addressed Berker's comments. Added versionchanged directives and a whatsnews entry.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Apr 8, 2015

    Ping.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Apr 10, 2015

    Updated patch addresses Antoines comments: refactores tests and corrects docs.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 16, 2015

    New changeset 09bd552999bf by Serhiy Storchaka in branch 'default':
    Issue bpo-16314: Added support for the LZMA compression in distutils.
    https://hg.python.org/cpython/rev/09bd552999bf

    @ned-deily
    Copy link
    Member

    ned-deily commented May 16, 2015

    The test for lzma being importable is not sufficient.

    ======================================================================
    ERROR: test_make_archive_xztar (distutils.tests.test_archive_util.ArchiveUtilTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Lib/tarfile.py", line 389, in __init__
        import lzma
      File "/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Lib/lzma.py", line 26, in <module>
        from _lzma import *
    ImportError: No module named '_lzma'

    http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/3171/steps/test/logs/stdio

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 16, 2015

    New changeset 25cb42a4bce9 by Serhiy Storchaka in branch 'default':
    Fixed issue bpo-16314 test for the case when lzma is not available.
    https://hg.python.org/cpython/rev/25cb42a4bce9

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants