-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xz compression in distutils #60518
Comments
The proposed patch adds xz compression support in additional to gzip, compress and bzip2 in distutils. |
I think there’s already a report for distutils2. For distutils, if we take the feature freeze seriously, this would have to be rejected. I know it looks innocuous, but distutils is brittle code widely monkey-patched, so I prefer to take no chances. |
OK, I didn't know that distutils are frozen. |
AFAIK distutils is no longer frozen. |
What about the patch? |
Code and doc changes look good. Will you add tests? |
Added tests for gztar, bztar and xztar. Added more asserts in other tests. |
Addressed Berker's comments. Added versionchanged directives and a whatsnews entry. |
Ping. |
Updated patch addresses Antoines comments: refactores tests and corrects docs. |
New changeset 09bd552999bf by Serhiy Storchaka in branch 'default': |
The test for lzma being importable is not sufficient. ====================================================================== Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Lib/tarfile.py", line 389, in __init__
import lzma
File "/Users/buildbot/buildarea/3.x.murray-snowleopard/build/Lib/lzma.py", line 26, in <module>
from _lzma import *
ImportError: No module named '_lzma' http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/3171/steps/test/logs/stdio |
New changeset 25cb42a4bce9 by Serhiy Storchaka in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: