Enhancement: give mock_open readline() and readlines() methods

[abadger]

BPO	17467
Nosy	@abadger, @voidspace
PRs	bpo-35717: Fix KeyError exception raised when using enums and compile #11523 bpo-35717: Fix KeyError exception raised when using enums and compile #11523 bpo-35717: Fix KeyError exception raised when using enums and compile #11523
Superseder	bpo-23004: mock_open() should allow reading binary data
Files	python3-mock_open-methods.patch: Patch mock_open to understand readline and readlines methods 01000-mock_open-methods.patch: 2nd version of mock_open readline/readlines patch 01000-mock_open-methods.patch: 3rd version of the mock_open patch -- docs and read/readline/readlines draw from the same read_data

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/voidspace'
closed_at = <Date 2013-03-20.00:22:57.778>
created_at = <Date 2013-03-18.20:09:13.694>
labels = ['type-feature']
title = 'Enhancement: give mock_open readline() and readlines() methods'
updated_at = <Date 2019-01-11.17:00:44.507>
user = 'https://github.com/abadger'

bugs.python.org fields:

activity = <Date 2019-01-11.17:00:44.507>
actor = 'remi.lapeyre'
assignee = 'michael.foord'
closed = True
closed_date = <Date 2013-03-20.00:22:57.778>
closer = 'python-dev'
components = []
creation = <Date 2013-03-18.20:09:13.694>
creator = 'a.badger'
dependencies = []
files = ['29454', '29479', '29484']
hgrepos = []
issue_num = 17467
keywords = ['patch', 'needs review']
message_count = 4.0
messages = ['184512', '184642', '184664', '184714']
nosy_count = 3.0
nosy_names = ['a.badger', 'michael.foord', 'python-dev']
pr_nums = ['11523', '11523', '11523']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = '23004'
type = 'enhancement'
url = 'https://bugs.python.org/issue17467'
versions = ['Python 3.4']

[abadger]

unittest.mock provides a mock_open convenience function1. The convenience function handled file.read() but does not handle file.readline() or file.readlines(). I'll attach a patch that adds support for both of these methods.

[abadger]

Updated patch that includes unittests and fixes readlines() newline behaviour.

[abadger]

3rd version of the patch.

• Added some documentation to untitest.mock.rst
• Changed the code so that read, readline, and readlines all deplete the same copy of read_data.

[python-dev]

New changeset 684b75600fa9 by Michael Foord in branch 'default':
Closes bpo-17467. Add readline and readlines support to unittest.mock.mock_open
http://hg.python.org/cpython/rev/684b75600fa9