-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support http.server passing bind address via commend line argument #61964
Comments
The http.server supports a shortcut to start it directly via the interpreter. To be able to use this shortcut on server with insecure interfaces, this patch adds a --bind, -b option to specify a bind address. |
I left comments on Rietveld. The patch also needs a documentation update. |
I have updated the patch and added a paragraph for this option to the documentation. Shall I add this issue to the changelog list for python 3.4.0 alpha 1? |
Thanks for proposing this and working on it Malte. Could you please submit a contributor agreement? (http://www.python.org/psf/contrib). We will add the Misc/NEWS entry when we commit the patch; that file changes so rapidly that any patch to it quickly becomes outdated. You could add an entry to Doc/whatsnew/3.4, though, if you were so moved. If not we'll add that too when we commit. For the doc patch, I think the first sentence would be clearer if it said "By default the server binds to all available interfaces." I'll probably tweak a couple other words for better English phrasing when I commit it, as well. |
New changeset a248655c8261 by Senthil Kumaran in branch 'default': |
Found the patch suitable and had addressed Berker Pesag's review comments too. Thanks for contributing, Malte Swart and thanks for submitting the contributor agreement too. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: