-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move imp.get_magic() to importlib #62392
Comments
As part of deprecating imp, need to move imp.get_magic() to importlib where it now belongs. Will be exposed as an attribute instead of a function, though. |
This could be an attribute on importlib.machinery.SourceLoader instead of an attribute in importlib.util. |
On Jun 11, 2013, at 08:44 PM, Brett Cannon wrote:
so, importlib.magic ? |
I'd like to see it be more easily accessible. |
So what are your arguments to making it more accessible? The typical user won't need to use it so I don't know if it really requires being off of importlib directly like find_loader, import_module, or (eventually) reload (which for convenience-sake while at the interpreter should be there). While I'm happy to entertain the argument that it should be importlib.machinery.MAGIC (like the file suffixes for the various file types) instead of importlib.abc.SourceLoader.magic, I don't want to make it importlib.magic. |
Any chance I could get a response to my questions, Barry, soon? I think I can finish the rest of the issues related to deprecating imp this weekend if we can settle this quickly. |
The only argument I have about it is that if someone *does* want to use, it should be fairly easily discoverable. Also, since it's a concrete value, it seems a little weird that it's stashed in an abc. I suppose importlib.machinery.MAGIC is better than importlib.abc.SourceLoader.magic |
I'll put it into importlib.util.MAGIC. |
On Jun 14, 2013, at 07:53 PM, Brett Cannon wrote:
+1 |
New changeset 5619bc2d8207 by Brett Cannon in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: