Move imp.reload() to importlib

[brettcannon]

BPO	18193
Nosy	@brettcannon, @berkerpeksag
Files	issue18193.diff issue18193_v2.diff issue18193_v3.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2013-06-14.19:06:02.229>
created_at = <Date 2013-06-11.20:45:11.039>
labels = ['library']
title = 'Move imp.reload() to importlib'
updated_at = <Date 2013-06-14.19:06:02.228>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-06-14.19:06:02.228>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2013-06-14.19:06:02.229>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2013-06-11.20:45:11.039>
creator = 'brett.cannon'
dependencies = []
files = ['30573', '30585', '30586']
hgrepos = []
issue_num = 18193
keywords = ['patch']
message_count = 7.0
messages = ['190982', '191070', '191140', '191141', '191142', '191144', '191145']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'Arfrever', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18193'
versions = ['Python 3.4']

[brettcannon]

For convenience it should live directly off of importlib and not importlib.util.

[berkerpeksag]

Here's a patch. Changes:

• Used types.ModuleType instead of type(sys)
• Updated imp and importlib docs
• Moved test_imp.ReloadTests to test_importlib.test_api.ReloadTests

[berkerpeksag]

Updated patch adressing Brett's comments.

[brettcannon]

Answered Berker's questions from the review. At this point Berker just needs to tweak one line in the test and it should then be good to go.

[brettcannon]

With Berker's nice use of TestCase.subTest() I think the patch is good to go! I should hopefully get this checked in today or tomorrow.

[python-dev]

New changeset 01da7bf11ca1 by Brett Cannon in branch 'default':
Issue bpo-18193: Add importlib.reload(), documenting (but not
http://hg.python.org/cpython/rev/01da7bf11ca1

[brettcannon]

Thanks for the patch, Berker!