Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_body and iter_attachments to provisional email API #62985

Closed
bitdancer opened this issue Aug 19, 2013 · 2 comments
Closed

Add get_body and iter_attachments to provisional email API #62985

bitdancer opened this issue Aug 19, 2013 · 2 comments
Labels
expert-email type-feature A feature request or enhancement

Comments

@bitdancer
Copy link
Member

bitdancer commented Aug 19, 2013

BPO 18785
Nosy @warsaw, @bitdancer
Superseder
  • bpo-18891: Master patch for content manager addition to email package
  • Files
  • get_body_iter_attachments.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-10-09.21:43:19.200>
    created_at = <Date 2013-08-19.21:24:42.751>
    labels = ['type-feature', 'expert-email']
    title = 'Add get_body and iter_attachments to provisional email API'
    updated_at = <Date 2013-10-09.21:43:19.199>
    user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2013-10-09.21:43:19.199>
    actor = 'r.david.murray'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-10-09.21:43:19.200>
    closer = 'r.david.murray'
    components = ['email']
    creation = <Date 2013-08-19.21:24:42.751>
    creator = 'r.david.murray'
    dependencies = []
    files = ['31379']
    hgrepos = []
    issue_num = 18785
    keywords = ['patch']
    message_count = 2.0
    messages = ['195669', '199347']
    nosy_count = 2.0
    nosy_names = ['barry', 'r.david.murray']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = 'resolved'
    status = 'closed'
    superseder = '18891'
    type = 'enhancement'
    url = 'https://bugs.python.org/issue18785'
    versions = ['Python 3.4']

    @bitdancer
    Copy link
    Member Author

    bitdancer commented Aug 19, 2013

    I'm working on completing the API changes for the email package for 3.4. This means I'm adding some more stuff to the current provisional API, which I will then aim to make non-provisional in 3.5.

    I've made a complete proposal to the email-sig, and have gotten some positive feedback but no detailed reviews yet.

    One part of the new API proposal is independent of the rest, and I've documented that part and implemented it. I'm posting the patch for that part. The patch includes some of the documentation for the rest, though not all of it...you can ignore all the doc changes in the new doc page except for the docs for the three new methods implemented by the patch for the purposes of reviewing this patch, though of course feedback on the (incomplete) rest is welcome.

    I'm posting this now because this part of the enhancement can be reviewed independently of the other changes.

    Note: I'm aware that MIMEMessage duplicates the name of a class in the mime subpackage. By the time I'm done that class will be deprecated (in 3.5). I haven't got that approved by the SIG yet, though, so it may change :)

    @bitdancer bitdancer added expert-email type-feature A feature request or enhancement labels Aug 19, 2013
    @bitdancer
    Copy link
    Member Author

    bitdancer commented Oct 9, 2013

    Serhiy's review comments were addressed by changes made on the master patch issue.

    Closing this one in favor of that one.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    expert-email type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant