-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtensionFileLoader missing get_filename() #63351
Comments
Any reason why ExtensionFileLoader does not implement get_filename()? I'm guessing it just slipped through the cracks. It should be there (and be registered as implementing ExecutionLoader). |
Just an oversight. |
New changeset 0d079c66dc23 by Eric Snow in branch 'default': |
I realized after I committed that this should probably be back-ported to 3.3. I'll take care of that in a few hours. |
New changeset 832579dbafd6 by Eric Snow in branch '3.3': |
Actually you need to back out the 3.3 commit. That's a new API in a bugfix release and that's bad. |
Dang it. I was thinking of it as a bug that the method wasn't there, but you're right regardless. Revert coming. |
New changeset 7ed717bd5faa by Eric Snow in branch '3.3': |
Thanks for noticing that, Brett. |
It would be good to add a versionadded(or versionchanged) tag. |
Good point. |
New changeset 62d045a873bb by Eric Snow in branch 'default': New changeset e9554199620f by Eric Snow in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: