Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of the cp1125 encoding #63867

Closed
serhiy-storchaka opened this issue Nov 20, 2013 · 12 comments
Closed

Add support of the cp1125 encoding #63867

serhiy-storchaka opened this issue Nov 20, 2013 · 12 comments
Labels
expert-unicode type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 20, 2013

BPO 19668
Nosy @malemburg, @loewis, @doerwalter, @vstinner, @ezio-melotti, @serhiy-storchaka
Files
  • encoding_cp1125.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-11-23.17:21:45.398>
    created_at = <Date 2013-11-20.19:35:02.340>
    labels = ['type-feature', 'expert-unicode']
    title = 'Add support of the cp1125 encoding'
    updated_at = <Date 2014-03-10.01:35:04.764>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-03-10.01:35:04.764>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-11-23.17:21:45.398>
    closer = 'serhiy.storchaka'
    components = ['Unicode']
    creation = <Date 2013-11-20.19:35:02.340>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['32733']
    hgrepos = []
    issue_num = 19668
    keywords = ['patch']
    message_count = 12.0
    messages = ['203523', '203558', '203559', '203584', '203594', '203598', '204010', '204047', '204056', '204059', '204064', '213009']
    nosy_count = 7.0
    nosy_names = ['lemburg', 'loewis', 'doerwalter', 'vstinner', 'ezio.melotti', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue19668'
    versions = ['Python 3.4']

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Nov 20, 2013

    The proposed patch adds support of the CP1125 encoding.

    The CP1125 encoding (also known as IBM866, CP866U (in Microsoft), 866nav (in TeX), RUSCII) is standard DOS encoding for Ukrainian language. It is only one DOS encoding (or at least most popular) suitable for Ukrainian. It is Ukrainian government standard for DOS. The CP1125 encoding differs from CP866 encoding only in 6 codes for Ukrainian letters.

    http://www-03.ibm.com/systems/resources/systems_i_software_globalization_pdf_cp01125z.pdf
    http://cp866u.codeplex.com/
    ftp://tug.org/texlive/Contents/live/texmf-dist/tex/latex/cyrillic/cp866nav.def
    http://segfault.kiev.ua/cyrillic-encodings/#ruscii

    @serhiy-storchaka serhiy-storchaka added expert-unicode type-feature A feature request or enhancement labels Nov 20, 2013
    @vstinner
    Copy link
    Member

    vstinner commented Nov 21, 2013

    See also issue bpo-19459.

    @vstinner
    Copy link
    Member

    vstinner commented Nov 21, 2013

    The proposed patch adds support of the CP1125 encoding.

    Nowadays, a good motivation for supporting a new codec is to be able to start Python 3. For example, I added cp65001 because some using try Python 3 with this Windows code page.

    It looks like at least one user is unable to start Python 3 because he/she uses GEORGIAN-PS as the locale encoding (issue bpo-19459).

    For cp1125: is it used as the ANSI code page on Windows? Otherwise, how do you use this encoding.

    Supporting all encodings in the world is meaningless because they are too many encodings.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Nov 21, 2013

    No, it is not official Microsoft codepage (it was introduced by IBM in its PC-DOS). AFAIK this encoding yet widely used in banking software. My old text files were written in this encoding, ;)

    @malemburg
    Copy link
    Member

    malemburg commented Nov 21, 2013

    On 21.11.2013 09:34, Serhiy Storchaka wrote:

    No, it is not official Microsoft codepage (it was introduced by IBM in its PC-DOS). AFAIK this encoding yet widely used in banking software. My old text files were written in this encoding, ;)

    +1 for adding this. It gets enough Google hits to be worth adding.

    Please also add the aliases you mentioned.

    Thanks,

    Marc-Andre Lemburg
    eGenix.com

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Nov 21, 2013

    Please also add the aliases you mentioned.

    I have already added these aliases.

    I should remove added in last moment the 'cp866nav' alias from Lib/encodings/aliases.py because it is actually a little different encoding (it have two Byelorussian letters "Ўў" instead cp866 characters "·√" at positions 0xfa-0xfb).

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Nov 23, 2013

    So what is a decision?

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 23, 2013

    +1

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 23, 2013

    New changeset d0fd68ef1aa9 by Serhiy Storchaka in branch 'default':
    Issue bpo-19668: Added support for the cp1125 encoding.
    http://hg.python.org/cpython/rev/d0fd68ef1aa9

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Nov 23, 2013

    Thanks all.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 23, 2013

    New changeset 355d8950f574 by Serhiy Storchaka in branch 'default':
    Fixed incorrectly applying a patch for bpo-19668.
    http://hg.python.org/cpython/rev/355d8950f574

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 10, 2014

    New changeset 11bc9f669015 by R David Murray in branch 'default':
    whatsnew: cp1125 codec (bpo-19668).
    http://hg.python.org/cpython/rev/11bc9f669015

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    expert-unicode type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants