Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WebP image format detection in imghdr module #64396

Closed
akhenakh mannequin opened this issue Jan 8, 2014 · 5 comments
Closed

Support WebP image format detection in imghdr module #64396

akhenakh mannequin opened this issue Jan 8, 2014 · 5 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@akhenakh
Copy link
Mannequin

akhenakh mannequin commented Jan 8, 2014

BPO 20197
Nosy @gpshead, @PCManticore, @berkerpeksag, @serhiy-storchaka
Files
  • imghdr_webp.patch
  • issue20197.patch
  • issue20197_v1.patch: Add comma for cleaner future patches.
  • issue20197_v2.patch: Add versionchanged.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2014-05-25.09:31:55.486>
    created_at = <Date 2014-01-08.21:38:19.381>
    labels = ['type-feature', 'library']
    title = 'Support WebP image format detection in imghdr module'
    updated_at = <Date 2014-05-25.09:31:55.484>
    user = 'https://bugs.python.org/akhenakh'

    bugs.python.org fields:

    activity = <Date 2014-05-25.09:31:55.484>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2014-05-25.09:31:55.486>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2014-01-08.21:38:19.381>
    creator = 'akhenakh'
    dependencies = []
    files = ['33366', '34338', '34341', '34344']
    hgrepos = []
    issue_num = 20197
    keywords = ['patch']
    message_count = 5.0
    messages = ['207702', '208646', '213074', '219076', '219077']
    nosy_count = 7.0
    nosy_names = ['gregory.p.smith', 'Claudiu.Popa', 'python-dev', 'berker.peksag', 'serhiy.storchaka', 'xcombelle', 'akhenakh']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue20197'
    versions = ['Python 3.5']

    @akhenakh
    Copy link
    Mannequin Author

    akhenakh mannequin commented Jan 8, 2014

    Detect the webp file format (RIFF container + WEBP), return webp as format detected.

    @akhenakh akhenakh mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 8, 2014
    @serhiy-storchaka
    Copy link
    Member

    serhiy-storchaka commented Jan 21, 2014

    LGTM. Detecting function matches the WebP specification [1].

    [1] https://developers.google.com/speed/webp/docs/riff_container#webp-file-header

    @PCManticore
    Copy link
    Mannequin

    PCManticore mannequin commented Mar 10, 2014

    Thanks for your patch, Fabrice!

    I've uploaded a change to your patch, by adding a .webp test file and adding the .webp format in imghdr's test suite.

    @serhiy-storchaka serhiy-storchaka self-assigned this May 25, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 25, 2014

    New changeset 4fd17e28d4bf by Serhiy Storchaka in branch 'default':
    Issue bpo-20197: Added support for the WebP image type in the imghdr module.
    http://hg.python.org/cpython/rev/4fd17e28d4bf

    @serhiy-storchaka
    Copy link
    Member

    serhiy-storchaka commented May 25, 2014

    Thank you for your contribution Fabrice and Claudiu.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant