Make cgi.FieldStorage a context manager

[brettcannon]

BPO	20289
Nosy	@brettcannon, @berkerpeksag, @serhiy-storchaka
Files	issue20289.diff issue20289_v2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-02-06.08:22:03.451>
created_at = <Date 2014-01-17.14:47:25.329>
labels = ['type-feature', 'library']
title = 'Make cgi.FieldStorage a context manager'
updated_at = <Date 2015-10-11.14:55:15.776>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2015-10-11.14:55:15.776>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-06.08:22:03.451>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2014-01-17.14:47:25.329>
creator = 'brett.cannon'
dependencies = []
files = ['33572', '38017']
hgrepos = []
issue_num = 20289
keywords = ['patch']
message_count = 10.0
messages = ['208338', '208579', '230737', '235405', '235418', '235437', '235470', '235471', '239147', '252808']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20289'
versions = ['Python 3.5']

[brettcannon]

It has a file attribute which contains a file, so making it so it can be closed faster than cgi.FieldStorage.__del__ would be good.

[berkerpeksag]

Here's a patch with a test and documentation update.

[serhiy-storchaka]

Added comments on Rietveld.

[serhiy-storchaka]

Ping.

[berkerpeksag]

Here's an updated patch. Thank you Serhiy.

[serhiy-storchaka]

LGTM.

[berkerpeksag]

Thanks for the review, Serhiy!

[python-dev]

New changeset 367f5e98ffbb by Berker Peksag in branch 'default':
Issue bpo-20289: cgi.FieldStorage() now supports the context management protocol.
https://hg.python.org/cpython/rev/367f5e98ffbb

[python-dev]

New changeset 34930a6faf0d by Serhiy Storchaka in branch 'default':
Issue bpo-20289: The copy module now uses pickle protocol 4 (PEP-3154) and
https://hg.python.org/cpython/rev/34930a6faf0d

[python-dev]

New changeset 80501740ab84 by Serhiy Storchaka in branch '3.5':
No longer skip tests for classes with __getnewargs_ex__. The copy module
https://hg.python.org/cpython/rev/80501740ab84

New changeset 6f4dd9bc1f20 by Serhiy Storchaka in branch 'default':
No longer skip tests for classes with __getnewargs_ex__. The copy module
https://hg.python.org/cpython/rev/6f4dd9bc1f20