Use specific asserts in bytes tests

[serhiy-storchaka]

BPO	20552
Nosy	@rhettinger, @terryjreedy, @vstinner, @serhiy-storchaka, @Mariatta
PRs	bpo-20552: Use specific asserts in bytes tests #790
Files	test_bytes_asserts.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-03-27.15:00:30.096>
created_at = <Date 2014-02-07.20:27:36.194>
labels = ['3.7', 'easy', 'type-feature', 'tests']
title = 'Use specific asserts in bytes tests'
updated_at = <Date 2017-03-27.15:00:30.095>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2017-03-27.15:00:30.095>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2017-03-27.15:00:30.096>
closer = 'terry.reedy'
components = ['Tests']
creation = <Date 2014-02-07.20:27:36.194>
creator = 'serhiy.storchaka'
dependencies = []
files = ['33976']
hgrepos = []
issue_num = 20552
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['210549', '211196', '290054', '290560', '290583', '290619']
nosy_count = 5.0
nosy_names = ['rhettinger', 'terry.reedy', 'vstinner', 'serhiy.storchaka', 'Mariatta']
pr_nums = ['790']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20552'
versions = ['Python 3.7']

[serhiy-storchaka]

The proposed patch makes bytes tests use more specific asserts. This will provide more useful failure report.

[rhettinger]

None of these should be backported.

[Mariatta]

I think this should only go to 3.7 now.

[terryjreedy]

Raymond, Am I correct in thinking that your comment is not specific to bytes but applies to all patches like this? If so, I think I agree because any future changes that break tests will almost certain happen in 3.7+, so that the extra work of backporting will have almost 0 gain. In a few years, the changes will be in all currently active branches for free.

[vstinner]

New changeset 604e74c by Victor Stinner (Serhiy Storchaka) in branch 'master':
bpo-20552: Use specific asserts in bytes tests (#790)
604e74c

[terryjreedy]

Close?