Use specific asserts in ipaddress tests

[serhiy-storchaka]

BPO	20553
Nosy	@ncoghlan, @serhiy-storchaka
Files	test_ipaddress_asserts.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-02-08.14:41:50.790>
created_at = <Date 2014-02-07.20:27:44.771>
labels = ['easy', 'type-feature', 'tests']
title = 'Use specific asserts in ipaddress tests'
updated_at = <Date 2014-02-08.14:41:50.789>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2014-02-08.14:41:50.789>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-02-08.14:41:50.790>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-02-07.20:27:44.771>
creator = 'serhiy.storchaka'
dependencies = []
files = ['33977']
hgrepos = []
issue_num = 20553
keywords = ['patch', 'easy']
message_count = 4.0
messages = ['210550', '210645', '210651', '210653']
nosy_count = 4.0
nosy_names = ['ncoghlan', 'pmoody', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20553'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

[serhiy-storchaka]

The proposed patch makes the ipaddress module tests use more specific asserts. This will provide more useful failure report.

[ncoghlan]

Changes look fine to me - I did just check in some other updates to test_ipaddress, but I believe they're far enough away from these that the patch should still apply.

[python-dev]

New changeset 58be80e7e653 by Serhiy Storchaka in branch '3.3':
Issue bpo-20553. Use specific asserts in ipaddress tests.
http://hg.python.org/cpython/rev/58be80e7e653

New changeset 2bcb574d579f by Serhiy Storchaka in branch 'default':
Issue bpo-20553. Use specific asserts in ipaddress tests.
http://hg.python.org/cpython/rev/2bcb574d579f

[serhiy-storchaka]

Thank you Nick for your review.